Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alias for mcape and mcin #195

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Add alias for mcape and mcin #195

merged 2 commits into from
Feb 14, 2023

Conversation

fedecutraro
Copy link
Contributor

As I commented in #194 calling variables mcape and mcin in getvar function gives an error. I added the alias for those variables to make it work.

@erogluorhan erogluorhan self-requested a review November 28, 2022 19:01
@erogluorhan erogluorhan linked an issue Nov 28, 2022 that may be closed by this pull request
@erogluorhan
Copy link
Collaborator

I am currently trying to figure out why this PR not triggered the gitHub Actions checks

@erogluorhan
Copy link
Collaborator

Hi @fedecutraro , could you please push an empty commit just to get GitHubA Actions checks triggered? You can do it by:

git commit --allow-empty -m "Empty-Commit to trigger GitHub Actions checks"

@fedecutraro
Copy link
Contributor Author

@erogluorhan I've just made the empty commit.

This is the first time I'm doing a pull request, maybe I forgot to do something?

@erogluorhan
Copy link
Collaborator

erogluorhan commented Nov 30, 2022

@erogluorhan I've just made the empty commit.

This is the first time I'm doing a pull request, maybe I forgot to do something?

No, it was not because of that! The automated GitHub Actions checks weren't triggered for some reason, but now after your empty commit, we got them triggered successfully. As we got that now, I will provide my review about the code as soon as I can.

Thanks very much for your contribution!

@erogluorhan erogluorhan merged commit a9543e6 into NCAR:develop Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variables mcape and mcin doesn´t work
2 participants