Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that in the last release it had a GitHub Action to deploy to PYPI, but looks like that's still not working (related to #170 & #176).
I imported the project into PyCharm, fixed a couple warnings, and then had the same error from GitHub Actions. In GH Actions, the error is as below.
Reproduced locally on a fresh virtual environment.
The issue is that we were expecting
importlib.util.find_spec('numpy')
to raise an error, but since 3.4 (wasfind_module
I believe) it returnsNone
when the module is not found.I simply raised the exception when the module returned is None, and that fixed the installation on my environment. Tested that running the installation again doesn't raise the issue.
Cheers,
Bruno