Mercator fix #174
Merged
Mercator fix #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erogluorhan
approved these changes
May 3, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should address the issue users are having when using Mercator projections in their wrfout files (seen in and closes #173). PR is set to merge directly to main as we have nothing else that would need to be released via a merge of develop into main.
Tested this by uninstalling wrf-python in my conda environment, making changes to the file on the branch, running
pip install .to install from source, then testing with a scratch file using a wrfout file that has a Mercator projection type. Cartopy version in environment is 0.20.2, which is the same version that was giving problems to users. Please feel free to test this locally as well before approving. I can send over the relevant code and wrfout file if necessary!