Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Mercator projection attributes #163

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Update Mercator projection attributes #163

merged 2 commits into from
Mar 9, 2022

Conversation

michaelavs
Copy link
Contributor

Addresses Issue #162

Removes previous self._xlimits and self._ylimits as Cartopy dropped support for them after 0.17, fixes by using self._x_limits and self._y_limits (Cartopy compliant).

Some points I think are worth noting for this PR:

  • In case of future user issues, I think we should drop support for Cartopy <= 0.20 as there were other major updates to Cartopy (and it's dependencies) that would make versions before 0.20 not work, but this will also reduce the scope of potential issues with any users who may be using very outdated versions of Cartopy.
  • I came across some interesting behaviors with this repo (specifically with fortran code) when to trying to create new tests and needed to instead do a very long winded work around between two environments and testing with code in the wrf-python tutorial repo, so this is possibly something we need to address going forward. This is also why you won't see a true test file for this bug fix, but I would be more than happy to show the outputs from my testing work around.

erogluorhan
erogluorhan approved these changes Mar 9, 2022
View reviewed changes
Copy link
Collaborator

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@erogluorhan erogluorhan merged commit d19e212 into develop Mar 9, 2022
erogluorhan pushed a commit that referenced this pull request Mar 16, 2022
@michaelavs @kwadrat
Merge Develop Into Main (#165)
086328f 
* proj4 formatting update (#146)

* units=hPa is used in /def get_slp():/

* Update Mercator projection attributes (#163)

* Update Mercator projection attributes

* remove empty test_mercator file

* CI issues (#164)

* CI issues

* Add build env path for Linux.yml

* other updates to ci file

* format more closely to uxarray/comp

* Undo some changes, add python version

* Revert to previous version for 'Run tests'

* Update version in conda recipe

Co-authored-by: Piotr Kasprzyk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erogluorhan erogluorhan erogluorhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelavs @erogluorhan