Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapting jcsda-internal/mpas-jedi#1030 #342

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

byoung-joo
Copy link
Collaborator

@byoung-joo byoung-joo commented Jan 23, 2025

Description

This PR adapts the changes required for jcsda-internal/mpas-jedi#1030.

  • The yaml structure for Control2Analysis linear variable change, which is used for multivariate B, needs to be revised.

Issue closed

Closes #341

Tests completed

Tier 1:

  • 3dvar_OIE120km_WarmStart
  • 3dvar_OIE120km_ColdStart
  • 3dvar_O30kmIE60km_ColdStart
  • eda_OIE120km_WarmStart
  • getkf_OIE120km_WarmStart
  • 3denvar_OIE120km_IAU_WarmStart
  • ForecastFromGFSAnalysesMPT
  • 4dhybrid_OIE120km_WarmStart

Tier 2 (optional):

  • GenerateGFSAnalyses
  • GenerateObs

 On branch feature/lvc_refactor
 Changes to be committed:
	modified:   config/jedi/applications/3dhybrid-allsky.yaml
	modified:   config/jedi/applications/3dhybrid.yaml
	modified:   config/jedi/applications/3dvar.yaml
	modified:   config/jedi/applications/4dhybrid.yaml
	modified:   initialize/framework/Build.py
@byoung-joo byoung-joo marked this pull request as ready for review January 23, 2025 22:03
@@ -44,7 +44,7 @@ def __init__(self, config:Config, model:Model=None):
self.variablesWithDefaults['mpas bundle'] = [config._bundle_dir, str]
else:
self.variablesWithDefaults['mpas bundle'] = \
['/glade/campaign/mmm/parc/ivette/pandac/codeBuild/mpasBundle_16Dec2024/build_SP', str] ## develop
['/glade/derecho/scratch/bjung/panda-c/code_lvc_refactor/mpas-bundle/build_single', str] ## develop
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build directory will be replaced with a permanent location after the corresponding mpas-jedi PR is merged.

 Changes to be committed:
	modified:   config/jedi/applications/3dhybrid-allsky.yaml
	modified:   config/jedi/applications/3dhybrid.yaml
	modified:   config/jedi/applications/3dvar.yaml
	modified:   config/jedi/applications/4dhybrid.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise YAML structure for multivariate B
1 participant