Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct right mouse drag in X behavior #283

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

gbburkhardt
Copy link
Contributor

Note: Filling out this template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the
maintainer's discretion.

Description of the Change

Correct change in heading by dragging the right mouse button in the X direction.

The desired behavior is to have the globe follow the mouse movement, e.g.,
when the mouse is above mid-screen, dragging the mouse to the right should
cause a clockwise rotation of the globe. The change from AWT to GL screen
coordinates had broken this. Thanks to Eugene Maksymenko (WorldWindEarth).

Why Should This Be In Core?

Restore original intent for mouse movements.

Benefits

More intuitive mouse control. Restore original intent for mouse movements.

Potential Drawbacks

None.

Applicable Issues

…n that is maintained by JOGAMP. Update JOGL jar files with released version 2.5.0, build Build: 2.5-b1533-20230818. That build includes the DPI scaling fix for TextRenderer, which was committed to the jogl repo on 6/4.
The desired behavior is to have the globe follow the mouse movement, e.g.,
when the mouse is above mid-screen, dragging the mouse to the right should
cause a clockwise rotation of the globe.  The change from AWT to GL screen
coordinates had broken this.  Thanks to Eugene Maksymenko (WorldWindEarth).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants