Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple updates to prod urls in datasets notebooks #152

Merged
merged 4 commits into from
Aug 17, 2024

Conversation

anayeaye
Copy link
Collaborator

@anayeaye anayeaye commented Jul 25, 2024

Small batch of simple notebook updates: new production api urls and modifications for pgstac titiler v1 breaking changes.

notebooks/datasets

  • air quality covid
  • ocean npp timeseries analysis
  • volcano so2 monitoring

notebooks/quickstarts

  • hls-visualization

missing from notebooks/datasets

nceo-biomass-statistics.ipynb needs more work: #153

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Jul 25, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://NASA-IMPACT.github.io/veda-docs/pr-preview/pr-152/
on branch gh-pages at 2024-08-16 21:23 UTC

@anayeaye anayeaye changed the title WIP Feat/prod urls in notebooks Simple updates to prod urls in datasets notebooks Aug 16, 2024
@anayeaye anayeaye marked this pull request as ready for review August 16, 2024 21:20
@smohiudd
Copy link
Collaborator

What about `nceo-biomass-statistics.ipynb"?

@smohiudd
Copy link
Collaborator

smohiudd commented Aug 16, 2024

Ignore comment above, read in the spreadsheet that you can't run in the hub.

"execution_count": null,
"metadata": {},
"outputs": [],
"source": []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, but if it's not too cumbersome, we can remove these two empty cells

Comment on lines +736 to +742
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {},
"outputs": [],
"source": []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {},
"outputs": [],
"source": []

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will remove the empty cell

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to save this for a new PR (maybe in the next?) I accidentally included these files in another PR and it will be way easier to resolve that if this gets merged as is

@anayeaye anayeaye merged commit bd1a23e into main Aug 17, 2024
2 checks passed
@anayeaye anayeaye deleted the feat/prod-urls-in-notebooks branch August 17, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants