Added affected curated urls count on url pattern pages #1169
Conversation
dhanur-sharma
commented
Dec 24, 2024
•
dhanur-sharma
commented
- Collection that is not curated and has delta URLs:
- Changing workflow status to Curated:
sde_collections/serializers.py
Outdated
| @@ -82,6 +83,10 @@ def get_delta_urls_count(self, obj): | |||
| titlepattern = obj.deltatitlepatterns.last() | |||
| return titlepattern.delta_urls.count() if titlepattern else 0 | |||
|
|
|||
| def get_curated_urls_count(self, obj): | |||
There was a problem hiding this comment.
I'm not sure if this is calculating a number that we actually want. By using last() it will give a random value that changes as new patterns are added. Also, it is supplying pattern data for a DeltaUrl. Can you check and see if these values can be removed entirely? Both get_curated_urls_count and get_delta_urls_count? Let's see how and where they are being used.
similarly, lets see if we can get rid of delta_urls_count, curated_urls_count, match_pattern_type.
also look at CuratedUrlSerializer.
There was a problem hiding this comment.
The curated_url_count is not needed in the DeltaURLSerializer and has been removed. Removing the delta_urls_count, curated_urls_count, match_pattern_type from the DeltaURLSerializer and CuratedURLSerializer will require more investigation.
