Merge pull request #700 from NAICNO/larstha-699-split

Fix #699 - vet uses of strings.Split
NAICNO · Nov 21, 2024 · bb1995d · bb1995d
2 parents 7a91fbb + 0a91e35
commit bb1995d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/code/sonalyze/cmd/args.go b/code/sonalyze/cmd/args.go
@@ -580,7 +580,7 @@ func (rs *RepeatableCommaSeparated[T]) String() string {
 }
 
 func (rs *RepeatableCommaSeparated[T]) Set(s string) error {
-	ys := strings.Split(s, ",")
+	ys := strings.Split(s, ",") // OK: "" is ruled out below
 	ws := make([]T, 0, len(ys))
 	for _, y := range ys {
 		if y == "" {

diff --git a/code/sonalyze/table/format.go b/code/sonalyze/table/format.go
@@ -112,8 +112,10 @@ func ParseFormatSpec(
 	if fmtOpt == "help" {
 		others["help"] = true
 	}
-	for _, fieldName := range strings.Split(spec, ",") {
-		fields, _ = addField(fieldName, fields, others, formatters, aliases)
+	if spec != "" {
+		for _, fieldName := range strings.Split(spec, ",") {
+			fields, _ = addField(fieldName, fields, others, formatters, aliases)
+		}
 	}
 	return fields, others, nil
 }