Various changes and optimisations to onboarding message and others. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ZProLegend007
commented
Jan 5, 2024
•
ZProLegend007
commented
- Add gradient template with purple colour to text "Mythic" on onboarding message.
- Add hex support for gradient overlay for "Mythic" text on onboarding message.
- Use Mythic gradient for "Mythic" text.
- Alter Mythic gradient to look acceptable in light and dark mode.
- Make next button on onboarding less prominent to encourage sign in.
- Change corner radius for sections in Home screen to 10 from 20 for consistency with Apple format.
…message. Use Mythic gradient for "Mythic" text. Alter Mythic gradient to look acceptable in light and dark mode. Make next button on onboarding less prominent to encourage sign in.
ZProLegend007
changed the title
Change corner radius for sections in Home screen to 10 from 20 for consistency with Apple format.
Change corner radius for sections in Home screen to 10 from 20 for consistency with Apple format.
ZProLegend007
changed the title
Signed-off-by: Zac <[email protected]>
There was a problem hiding this comment.
Good implementation, but it would be ideal to move the NSColor extension to a separate file in Mythic/Extensions
Signed-off-by: blackxfiied <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.