Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

오류 API 수정 #200

Merged
merged 12 commits into from
Oct 18, 2023
Merged

오류 API 수정 #200

merged 12 commits into from
Oct 18, 2023

Conversation

5uhwann
Copy link
Member

@5uhwann 5uhwann commented Oct 10, 2023

Issue

✅ 작업 내용

  • 졸업 계산 api

    • '학과' prefix 누락에 따른 유저 학과 매칭 오류 수정('학과' prefix추가)
    • 각 DetailCategoryResult의 haveToLectures 원소들의 id값 null 해결
    • 총 수강 학점 불일치 오류 해결(각 세부 카테고리 leftCredit 처리 시 takenCredit 감소 로직 추가)
    • 영어레벨에 맞지 않는 졸업과목 조회 수정
    • 총 졸업 학점 불일치 오류 해결(중복으로 계산되던 채플 학점 삭제)
  • 회원 탈퇴 api

    • 회원 탈퇴 시 parsingTextHistory 선 삭제 누락으로 인한 foreign key constraint 에러 해결

🤔 고민 했던 부분

🔊 도움이 필요한 부분!!

@5uhwann 5uhwann added the 🐛 fix 정상적으로 동작하지 않는 부분 수정 label Oct 10, 2023
@5uhwann 5uhwann added this to the 리팩토링 milestone Oct 10, 2023
@5uhwann 5uhwann requested a review from stophwan as a code owner October 10, 2023 13:52
@5uhwann 5uhwann self-assigned this Oct 10, 2023
@5uhwann 5uhwann requested a review from Hoya324 as a code owner October 10, 2023 13:52
@Hoya324
Copy link
Member

Hoya324 commented Oct 10, 2023

확인했습니다!

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #200 (2c8720d) into develop (c1aa188) will increase coverage by 0.78%.
Report is 1 commits behind head on develop.
The diff coverage is 91.66%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #200      +/-   ##
=============================================
+ Coverage      87.15%   87.93%   +0.78%     
- Complexity       840      866      +26     
=============================================
  Files            155      155              
  Lines           2366     2387      +21     
  Branches          60       60              
=============================================
+ Hits            2062     2099      +37     
+ Misses           274      256      -18     
- Partials          30       32       +2     
Files Coverage Δ
...aduatebe/graduation/domain/model/ChapelResult.java 100.00% <100.00%> (ø)
...tebe/graduation/domain/model/GraduationResult.java 100.00% <100.00%> (ø)
...demicalculture/BusinessBasicAcademicalManager.java 83.87% <ø> (ø)
...ain/service/major/exception/OptionalMandatory.java 100.00% <100.00%> (ø)
...rsistence/FindCommonCulturePersistenceAdapter.java 100.00% <100.00%> (ø)
...lecture/adapter/out/persistence/LectureMapper.java 100.00% <100.00%> (ø)
...tor/out/persistence/ParsingTextHistoryAdaptor.java 100.00% <100.00%> (ø)
...ptor/out/persistence/ParsingTextHistoryMapper.java 100.00% <ø> (ø)
...lication/service/withdraw/WithDrawUserService.java 100.00% <100.00%> (ø)
...e/myongjigraduatebe/user/domain/model/College.java 100.00% <100.00%> (ø)
... and 3 more

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1aa188...2c8720d. Read the comment docs.

@5uhwann 5uhwann added the ♻️ refactor 기본의 로직 변경 없이 코드 개선 label Oct 17, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@5uhwann 5uhwann merged commit 04b55a8 into develop Oct 18, 2023
6 checks passed
@5uhwann 5uhwann deleted the refactor/api_fix branch October 18, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 fix 정상적으로 동작하지 않는 부분 수정 ♻️ refactor 기본의 로직 변경 없이 코드 개선 size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants