-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MyoArm with no hand #29
base: dev
Are you sure you want to change the base?
Conversation
This file is not needed as Vittorio suggested to include the hand bones and joints for the reaching environment (just exclude the hand tendons and muscles).
Site added at the tip of the forearm, for use as an end effector in the new myoArmReachFixed-v0 and myoArmReachRandom-v0 environments.
Vittorio suggested to include the hand bones and joints for the reaching tasks (previously excluded) and just exclude the hand tendons and muscles. The file has been updated to reflect this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesheald can you remove the comments? also, can you add a snapshot with the description of # muscles | # joints for the Readme?
|
||
|
||
|
||
<!-- <spatial name="ECRL_tendon" class="forearm_muscle"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove the commented parrs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vittorio-Caggiano I'll create a screenshot and a short description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done this. See the latest file changes to PR 232. I have added two descriptions/images, one for the model and one for the task.
+1 on this point. We are creating a redundancy that will be hard to maintain or keep in sync. We should explore ideas before committing to this path. |
indeed. We are temporarily accepting redundancy (hand replicated in arm). We need a more comprehensive long term approach |
I have advocated for an attach functionality that is live and stable now. Perhaps it is time to look into adopting these - https://mujoco.readthedocs.io/en/stable/XMLreference.html#body-attach We need more clarity on
|
I do not think it is possible to completely separate arm from forearm ... we might need to decompose it |
In that case, we need to move to using mjSpec for model editing. We will have to bump MuJoCo version for this feature. |
These xml files are needed for PR 232.
Following Vittorio's advice, I have created a myoArm model that has no hand or hand muscles, for use in a pure reaching task.
I have created two new files:
There is currently redundancy, as the arm-with-no-hand model is contained within the full arm model. A cleaner solution would be to define the full arm model as the arm-with-no-hand model with the hand included. However, as a first pass, I thought I would add these files rather than modify the full arm model.