Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyoArm with no hand #29

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Conversation

jamesheald
Copy link

These xml files are needed for PR 232.

Following Vittorio's advice, I have created a myoArm model that has no hand or hand muscles, for use in a pure reaching task.

I have created two new files:

  1. myoarm_nohand_body.xml is a modification of myoarm_body.xml. All I have done is i) comment out the lines we don't need, and ii) added a new site at the end of the forearm called forearm_tip, which will act as the end effector in the reaching task.
  2. myoarm_nohand_assets.xml is a modification of myoarm_assets.xml. All I have done is comment out the lines we don't need.

There is currently redundancy, as the arm-with-no-hand model is contained within the full arm model. A cleaner solution would be to define the full arm model as the arm-with-no-hand model with the hand included. However, as a first pass, I thought I would add these files rather than modify the full arm model.

This file is not needed as Vittorio suggested to include the hand bones and joints for the reaching environment (just exclude the hand tendons and muscles).
Site added at the tip of the forearm, for use as an end effector in the new myoArmReachFixed-v0 and myoArmReachRandom-v0 environments.
Vittorio suggested to include the hand bones and joints for the reaching tasks (previously excluded) and just exclude the hand tendons and muscles. The file has been updated to reflect this change.
@Vittorio-Caggiano Vittorio-Caggiano changed the base branch from main to dev November 30, 2024 15:57
@vikashplus vikashplus deleted the branch MyoHub:dev December 2, 2024 20:06
@vikashplus vikashplus closed this Dec 2, 2024
Copy link
Contributor

@Vittorio-Caggiano Vittorio-Caggiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesheald can you remove the comments? also, can you add a snapshot with the description of # muscles | # joints for the Readme?




<!-- <spatial name="ECRL_tendon" class="forearm_muscle">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove the commented parrs

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vittorio-Caggiano I'll create a screenshot and a short description

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done this. See the latest file changes to PR 232. I have added two descriptions/images, one for the model and one for the task.

@vikashplus
Copy link
Contributor

There is currently redundancy, as the arm-with-no-hand model is contained within the full arm model. A cleaner solution would be to define the full arm model as the arm-with-no-hand model with the hand included. However, as a first pass, I thought I would add these files rather than modify the full-arm model.

+1 on this point. We are creating a redundancy that will be hard to maintain or keep in sync. We should explore ideas before committing to this path.

@Vittorio-Caggiano
Copy link
Contributor

Vittorio-Caggiano commented Dec 15, 2024

There is currently redundancy, as the arm-with-no-hand model is contained within the full arm model. A cleaner solution would be to define the full arm model as the arm-with-no-hand model with the hand included. However, as a first pass, I thought I would add these files rather than modify the full-arm model.

+1 on this point. We are creating a redundancy that will be hard to maintain or keep in sync. We should explore ideas before committing to this path.

indeed. We are temporarily accepting redundancy (hand replicated in arm). We need a more comprehensive long term approach

@vikashplus
Copy link
Contributor

vikashplus commented Dec 15, 2024

I have advocated for an attach functionality that is live and stable now. Perhaps it is time to look into adopting these - https://mujoco.readthedocs.io/en/stable/XMLreference.html#body-attach

We need more clarity on

  • Attach assumes clean separation. Are hands and arms cleanly separable? In other words, are there any tendons that span both hands and arms?
  • If that is not the case, we should look into mjSpec to decompose full arm model. We will need to detach arm from the hand in this case.

@Vittorio-Caggiano
Copy link
Contributor

I do not think it is possible to completely separate arm from forearm ... we might need to decompose it

@vikashplus
Copy link
Contributor

In that case, we need to move to using mjSpec for model editing. We will have to bump MuJoCo version for this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants