Cleanup TODO notes, remove old preview args from build.gradle

MyWorldLLC · Jun 21, 2024 · 2e30105 · 2e30105
1 parent 065ae75
commit 2e30105
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/lib/build.gradle b/lib/build.gradle
@@ -29,26 +29,18 @@ java {
     }
 }
 
-tasks.withType(JavaCompile).configureEach {
-    //options.compilerArgs.add('--enable-preview')
-}
-
 tasks.withType(Test).configureEach {
-    //jvmArgs += '--enable-preview'
     jvmArgs += '--enable-native-access=ALL-UNNAMED'
 }
 
 compileTestGroovy {
-    //options.compilerArgs.add('--enable-preview')
     options.compilerArgs.add('--enable-native-access=ALL-UNNAMED')
 }
 
 test {
     useJUnitPlatform()
-    // TODO - support non-Linux lib names
     systemProperty "buoy.test.lib.path", new File(parent.projectDir.absoluteFile, "native/build/lib/main/debug/").toPath().toString()
     jvmArgs(['--enable-native-access=ALL-UNNAMED'])
-    //jvmArgs(['--enable-preview', '--enable-native-access=ALL-UNNAMED'])
 }
 
 publishing {

diff --git a/lib/src/main/java/com/myworldvw/buoy/mapping/FieldHandler.java b/lib/src/main/java/com/myworldvw/buoy/mapping/FieldHandler.java
@@ -41,8 +41,9 @@ public FieldHandler(FieldDef model, Field field){
         this.field = field;
     }
 
-    // TODO - this doesn't work if this field references a struct value, since structs
+    // Note that this doesn't work if this field references a struct value, since structs
     // are not value layouts in Panama and the VarHandle can only access a value layout.
+    // To access nested structs, use a struct model class.
     public VarHandle getHandle(MemoryLayout layout){
         var handle = layout.varHandle(MemoryLayout.PathElement.groupElement(model.name()));
         return MethodHandles.insertCoordinates(handle, 1, 0L);