fix(agent): missing counter variable (#150)

MyUnisoft · Nov 14, 2023 · 99dfc19 · 99dfc19
1 parent 46d37d0
commit 99dfc19
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/.github/workflows/agent.yml b/.github/workflows/agent.yml
@@ -19,8 +19,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        # TODO: v18 temporarily disabled due to https://github.com/MyUnisoft/sigyn/actions/runs/6716893006/job/18253814002
-        node-version: [20.x]
+        node-version: [18.x, 20.x]
       fail-fast: false
     steps:
       - name: Harden Runner
@@ -29,7 +28,7 @@ jobs:
           egress-policy: audit
       - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
+        uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
         with:
           node-version: ${{ matrix.node-version }}
       - name: Install dependencies

diff --git a/src/agent/src/notifiers/rules.notifier.ts b/src/agent/src/notifiers/rules.notifier.ts
@@ -125,6 +125,7 @@ export class RuleNotifier extends Notifier<RuleNotifierAlert> {
       ruleConfig,
       ruleName: rule.name,
       count: rule.counter,
+      counter: rule.threshold,
       threshold: ruleConfig.alert.on.count,
       interval: ruleConfig.alert.on.interval,
       label: { ...new StreamSelector(ruleConfig.logql).kv(), ...rule.labels },

diff --git a/src/config/src/utils/compositeRules.ts b/src/config/src/utils/compositeRules.ts
@@ -63,7 +63,7 @@ export function handleTemplates(
     return [];
   }
 
-  const clonedRules = structuredClone(compositeRules);
+  const clonedRules = JSON.parse(JSON.stringify((compositeRules)));
 
   for (const rule of clonedRules) {
     if (typeof rule.template === "object" && rule.template.extends) {

diff --git a/src/notifiers/src/webhook.ts b/src/notifiers/src/webhook.ts
@@ -28,9 +28,9 @@ export class WebhookNotifier {
   };
 
   constructor(options: ExecuteWebhookOptions) {
-    this.webhookUrl = structuredClone(options.webhookUrl);
-    this.data = structuredClone(options.data);
-    this.template = structuredClone(options.template);
+    this.webhookUrl = JSON.parse(JSON.stringify((options.webhookUrl)));
+    this.data = JSON.parse(JSON.stringify((options.data)));
+    this.template = JSON.parse(JSON.stringify((options.template)));
 
     this.#headers = {
       "content-type": "application/json"