Skip to content

Commit

Permalink
chore: use node 20.x in container and build with node 18.x
Browse files Browse the repository at this point in the history
  • Loading branch information
Dafyh committed Jul 29, 2024
1 parent fd6f599 commit db7ef51
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .github/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
ARG PLATFORM

FROM myunisoft91/heif-converter.$PLATFORM:v0.0.1
FROM myunisoft91/heif-converter.$PLATFORM
LABEL maintainer="Nicolas Marteau <[email protected]>"

WORKDIR heif-converter
COPY . .
RUN npm install
RUN npm run configure
RUN npm run build
RUN npm run configure -- --target=v18.12.0
RUN npm run build -- --target=v18.12.0
RUN npm run test
2 changes: 1 addition & 1 deletion platform/linux-x64/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ RUN apt-get update && \
python3-mako \
&& rm -rf /var/lib/apt/lists/*

RUN curl -sL https://deb.nodesource.com/setup_18.x | bash - && \
RUN curl -sL https://deb.nodesource.com/setup_20.x | bash - && \
apt-get install -y nodejs

RUN git clone https://github.com/microsoft/vcpkg.git && \
Expand Down
2 changes: 1 addition & 1 deletion platform/win32-ia32/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ RUN powershell -NoProfile -ExecutionPolicy Bypass -Command \
[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072; \
iex ((New-Object System.Net.WebClient).DownloadString('https://chocolatey.org/install.ps1'))"

RUN choco install -y nodejs --version=18.12.0 --x86
RUN choco install -y nodejs --version=20.9.0 --x86
RUN choco install -y git visualstudio2019buildtools visualstudio2019-workload-vctools
RUN choco install -y python3

Expand Down
2 changes: 1 addition & 1 deletion platform/win32-x64/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ RUN powershell -NoProfile -ExecutionPolicy Bypass -Command \
[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072; \
iex ((New-Object System.Net.WebClient).DownloadString('https://chocolatey.org/install.ps1'))"

RUN choco install -y nodejs --version=18.12.0
RUN choco install -y nodejs --version=20.9.0
RUN choco install -y git visualstudio2019buildtools visualstudio2019-workload-vctools
RUN choco install -y python3

Expand Down

0 comments on commit db7ef51

Please sign in to comment.