Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Prepare the 8.7.0 release #742

Merged
merged 1 commit into from
Oct 27, 2024
Merged

[TASK] Prepare the 8.7.0 release #742

merged 1 commit into from
Oct 27, 2024

Conversation

oliverklee
Copy link
Contributor

No description provided.

@oliverklee oliverklee added this to the 8.6.1 or 8.7.0 milestone Oct 24, 2024
@oliverklee oliverklee requested a review from JakeQZ October 24, 2024 16:26
@oliverklee oliverklee self-assigned this Oct 24, 2024
JakeQZ
JakeQZ reviewed Oct 24, 2024
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does now work with Emogrifier-dev on PHP 8.4?

@oliverklee oliverklee marked this pull request as draft October 24, 2024 17:15
@oliverklee
Copy link
Contributor Author

Sigh. It seems we still need to fix some more places after all for PHP 8.4 compatibility for Emogrifier. (I wonder why the tests for PHP-CSS-Parser do not catch this.)
MyIntervals/emogrifier#1304

@JakeQZ
Copy link
Contributor

JakeQZ commented Oct 24, 2024

Sigh. It seems we still need to fix some more places after all for PHP 8.4 compatibility for Emogrifier.

Possibly needs something for #677.

(I wonder why the tests for PHP-CSS-Parser do not catch this.) MyIntervals/emogrifier#1304

That is indeed strange, since we are running unit tests with PHP 8.4, which will surely call CSSList\Document::render(). Are deprecation warnings disabled in the PHPUnit config?

@oliverklee
Copy link
Contributor Author

Are deprecation warnings disabled in the PHPUnit config?

Indeed: #744

@oliverklee oliverklee added the release PRs for creating a new release label Oct 26, 2024
@oliverklee oliverklee marked this pull request as ready for review October 27, 2024 07:17
@oliverklee oliverklee requested a review from JakeQZ October 27, 2024 07:21
@oliverklee oliverklee marked this pull request as draft October 27, 2024 07:22
@oliverklee
Copy link
Contributor Author

Sigh. And another nullable-by-default parameter that isn't covered by the the parser tests yet: https://github.com/MyIntervals/emogrifier/actions/runs/11538536814/job/32117129042?pr=1304

@oliverklee oliverklee marked this pull request as ready for review October 27, 2024 17:24
@oliverklee
Copy link
Contributor Author

Now the Emogrifier CI build is green with the latest changes in the v8.x branch of PHP-CSS-Parser: MyIntervals/emogrifier#1304

I think 8.7.0 is ready to get released.

JakeQZ
JakeQZ approved these changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the Emogrifier CI build is green with the latest changes in the v8.x branch of PHP-CSS-Parser: MyIntervals/emogrifier#1304

PHPUnit with dependencies=lowest is still failing but that's due to an issue with Symfony.

@JakeQZ JakeQZ merged commit f414ff9 into v8.x Oct 27, 2024
25 checks passed
@JakeQZ JakeQZ deleted the task/release branch October 27, 2024 17:38
@oliverklee
Copy link
Contributor Author

I have just released version 8.7.0: https://github.com/MyIntervals/PHP-CSS-Parser/releases/tag/v8.7.0

westonruter added a commit to westonruter/PHP-CSS-Parser that referenced this pull request Nov 4, 2024
@westonruter
Merge branch 'v8.x' of https://github.com/MyIntervals/PHP-CSS-Parser …
21a5de3 
…into fix/malformed-identifier

* 'v8.x' of https://github.com/MyIntervals/PHP-CSS-Parser: (46 commits)
  [CLEANUP] Autoformat the code (MyIntervals#749)
  [TASK] Prepare the 8.7.0 release (MyIntervals#742)
  [BUGFIX] Fix another implictly nullable parameter (MyIntervals#751)
  [CLEANUP] Autoformat the changelog (MyIntervals#750)
  [TASK] Configure PHPUnit to be more strict (MyIntervals#744)
  [BUGFIX] Avoid implicit nullable parameters (MyIntervals#746)
  [BUGFIX] Revert broken support for multiple comments (MyIntervals#741)
  [TASK] Add some more tests for parsing comments (MyIntervals#739)
  [TASK] Use fixed PHPUnit versions (MyIntervals#726)
  [TASK] Update PHPUnit (MyIntervals#725)
  [TASK] State since which version code is `@internal`/`@deprecated` (MyIntervals#723)
  [TASK] Deprecate the expansion of shorthand properties (MyIntervals#719)
  [TASK] Mark parsing-internal classes and methods as `@internal` (MyIntervals#711)
  [TASK] Deprecate `Parser::setCharset()` and `Parser::getCharset()` (MyIntervals#703)
  [FEATURE] Run the tests on CI with PHP 8.4 as well (MyIntervals#701)
  [TASK] Run the tests with PHP versions up to 8.3 (MyIntervals#697)
  [TASK] Also allow higher versions of PHPUnit (MyIntervals#682)
  [BUGFIX] Fix type errors in PHP strict mode (MyIntervals#695)
  [TASK] Block installations on unsupported higher PHP versions (MyIntervals#692)
  [BUGFIX] Avoid using `setUp()` in testcases (MyIntervals#683)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vagabond2522 vagabond2522 vagabond2522 approved these changes

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
release PRs for creating a new release
Projects
None yet
Milestone
8.7.0: Add support for PHP 8.4
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @JakeQZ @vagabond2522