Skip to content

Commit

Permalink
Added check for sign validity. Fixed #379
Browse files Browse the repository at this point in the history
  • Loading branch information
MuresanSergiu committed Oct 31, 2015
1 parent f8d2dbc commit 9527adb
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions src/main/java/myessentials/entities/sign/Sign.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package myessentials.entities.sign;

import myessentials.MyEssentialsCore;
import myessentials.entities.BlockPos;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
Expand Down Expand Up @@ -28,6 +29,8 @@ public abstract class Sign {

protected abstract String[] getText();

protected abstract boolean isValid();

public void onShiftRightClick(EntityPlayer player) {
}

Expand Down Expand Up @@ -75,6 +78,16 @@ public void deleteSignBlock() {
}

public static class Container extends ArrayList<Sign> {
@Override
public boolean add(Sign sign) {
if(sign.isValid()) {
return super.add(sign);
} else {
MyEssentialsCore.instance.LOG.error("Failed to validate a special sign at location ({}, {}, {}; DIM: {})", sign.bp.getX(), sign.bp.getY(), sign.bp.getZ(), sign.bp.getDim());
return false;
}
}

public Sign get(BlockPos bp) {
for(Sign sign : this) {
if(bp.equals(sign.bp)) {
Expand Down

0 comments on commit 9527adb

Please sign in to comment.