This repository has been archived by the owner on Feb 3, 2025. It is now read-only.
Unfilter force cloes balance #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
unfilter-fc-bal
branch
from
c8c994b to
40827dd
Compare
TonyGiorgio
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
True, it's more rare when a normal close happens anyways for the time being. And when force closes can result in potential on chain transactions waiting to confirm at previous fee rates, it is necessary to show something rather than nothing.
though are transaction activity items not showing up either then?
those still show up |
TonyGiorgio
reviewed
Nov 17, 2023
benthecarman
force-pushed
the
unfilter-fc-bal
branch
from
40827dd to
121e5be
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #862
This was a bug from #825 turns out this counts towards both mutual closes and force closes. lightningdevkit/rust-lightning#2738 will allow us to truly fix.
Force closes are more common (and scary) in Mutiny so for now would be better to have the bug be around mutual closes.
Don't think we can write a test for this without mocking
chain_monitorandchannel_manager