Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block zeus pay node for nwc #854

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Block zeus pay node for nwc #854

merged 1 commit into from
Nov 14, 2023

Conversation

benthecarman
Copy link
Collaborator

@benthecarman benthecarman commented Nov 14, 2023

If a user wants to pay to a zeus pay address explicitly we should allow them but often over nwc they user is just randomly sending payments, not knowing where they are going and this can cause force closures. So lets just stop payments to zeus pay over nwc for now.

Helps with #826

@TonyGiorgio
Copy link
Contributor

Are you sure it goes to this node and not an intermediary zaplocker one?

@benthecarman
Copy link
Collaborator Author

Are you sure it goes to this node and not an intermediary zaplocker one?

this is the node id I got from the invoice when getting from https://zeuspay.com/api/lnurl/pay/benthecarman?amount=1000000

@TonyGiorgio TonyGiorgio merged commit 8801819 into master Nov 14, 2023
9 checks passed
@TonyGiorgio TonyGiorgio deleted the block-zeus branch November 14, 2023 17:15
@supertestnet
Copy link

supertestnet commented Nov 14, 2023

I think this is wise. Perhaps, in the future, mobile users will be able to safely pay hodl invoices. But right now they cannot.

Also consider generalizing this solution to all zaplocker nodes. (As far as I'm aware, only myself and Evan are currently running zaplocker, but I hope more people join us.) Consider this link: https://zeuspay.com/api/lnurl/pay/benthecarman?amount=1000000

The json it serves has a key/value pair that says "hodl_invoice: true"

All (i.e. both) zaplocker nodes show this key/value pair. So consider not paying invoices if retrieved from an endpoint that shares that key/value pair.

@TonyGiorgio
Copy link
Contributor

I think this is wise. Perhaps, in the future, mobile users will be able to safely pay hodl invoices. But right now they cannot.

Be aware that there is an easy way to generalize this solution to all zaplocker nodes. (As far as I'm aware, only myself and Evan are currently running zaplocker, but I hope more people join us.) Consider this link: https://zeuspay.com/api/lnurl/pay/benthecarman?amount=1000000

The json it serves has a key/value pair that says "hodl_invoice: true"

All (i.e. both) zaplocker nodes show this key/value pair. So consider not paying invoices if retrieved from an endpoint that shares that key/value pair.

This is not an option because we are not pulling the LNURL directly, the invoice is coming from nostr clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants