Properly implement entryfee for world config #190
Annotations
1 error and 11 warnings
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
|
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
src/main/java/org/mvplugins/multiverse/core/economy/MVEconomist.java#L18
[checkstyle] reported by reviewdog 🐶
Missing a Javadoc comment.
Raw Output:
/github/workspace/./src/main/java/org/mvplugins/multiverse/core/economy/MVEconomist.java:18:5: warning: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck)
|
src/main/java/org/mvplugins/multiverse/core/world/MultiverseWorld.java#L390
[checkstyle] reported by reviewdog 🐶
First sentence should end with a period.
Raw Output:
/github/workspace/./src/main/java/org/mvplugins/multiverse/core/world/MultiverseWorld.java:390:0: warning: First sentence should end with a period. (com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck)
|
src/main/java/org/mvplugins/multiverse/core/world/MultiverseWorld.java#L390
[checkstyle] reported by reviewdog 🐶
First sentence of Javadoc is missing an ending period.
Raw Output:
/github/workspace/./src/main/java/org/mvplugins/multiverse/core/world/MultiverseWorld.java:390:0: warning: First sentence of Javadoc is missing an ending period. (com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck)
|
src/main/java/org/mvplugins/multiverse/core/world/MultiverseWorld.java#L399
[checkstyle] reported by reviewdog 🐶
First sentence should end with a period.
Raw Output:
/github/workspace/./src/main/java/org/mvplugins/multiverse/core/world/MultiverseWorld.java:399:0: warning: First sentence should end with a period. (com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocStyleCheck)
|
src/main/java/org/mvplugins/multiverse/core/world/MultiverseWorld.java#L399
[checkstyle] reported by reviewdog 🐶
First sentence of Javadoc is missing an ending period.
Raw Output:
/github/workspace/./src/main/java/org/mvplugins/multiverse/core/world/MultiverseWorld.java:399:0: warning: First sentence of Javadoc is missing an ending period. (com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck)
|
src/main/java/org/mvplugins/multiverse/core/world/config/CurrencySerializer.java#L7
[checkstyle] reported by reviewdog 🐶
'org.mvplugins.multiverse.core.configuration.functions.NodeSerializer' should be separated from previous imports.
Raw Output:
/github/workspace/./src/main/java/org/mvplugins/multiverse/core/world/config/CurrencySerializer.java:7:1: warning: 'org.mvplugins.multiverse.core.configuration.functions.NodeSerializer' should be separated from previous imports. (com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck)
|
src/main/java/org/mvplugins/multiverse/core/world/config/CurrencySerializer.java#L16
[checkstyle] reported by reviewdog 🐶
Missing a Javadoc comment.
Raw Output:
/github/workspace/./src/main/java/org/mvplugins/multiverse/core/world/config/CurrencySerializer.java:16:5: warning: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck)
|
src/main/java/org/mvplugins/multiverse/core/world/config/EntryFeeMigrator.java#L5
[checkstyle] reported by reviewdog 🐶
'org.mvplugins.multiverse.core.configuration.migration.MigratorAction' should be separated from previous imports.
Raw Output:
/github/workspace/./src/main/java/org/mvplugins/multiverse/core/world/config/EntryFeeMigrator.java:5:1: warning: 'org.mvplugins.multiverse.core.configuration.migration.MigratorAction' should be separated from previous imports. (com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck)
|
src/main/java/org/mvplugins/multiverse/core/world/config/EntryFeeMigrator.java#L11
[checkstyle] reported by reviewdog 🐶
Class 'EntryFeeMigrator' looks like designed for extension (can be subclassed), but the method 'migrate' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'EntryFeeMigrator' final or making the method 'migrate' static/final/abstract/empty, or adding allowed annotation for the method.
Raw Output:
/github/workspace/./src/main/java/org/mvplugins/multiverse/core/world/config/EntryFeeMigrator.java:11:5: info: Class 'EntryFeeMigrator' looks like designed for extension (can be subclassed), but the method 'migrate' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'EntryFeeMigrator' final or making the method 'migrate' static/final/abstract/empty, or adding allowed annotation for the method. (com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck)
|
src/main/java/org/mvplugins/multiverse/core/world/config/EntryFeeMigrator.java#L13
[checkstyle] reported by reviewdog 🐶
The String "entry-fee.currency" appears 2 times in the file.
Raw Output:
/github/workspace/./src/main/java/org/mvplugins/multiverse/core/world/config/EntryFeeMigrator.java:13:44: warning: The String "entry-fee.currency" appears 2 times in the file. (com.puppycrawl.tools.checkstyle.checks.coding.MultipleStringLiteralsCheck)
|
This job succeeded
Loading