multi plugin hk2 support #185
pr.checkstyle.yml
on: pull_request
checkstyle
/
checkstyle
23s
Annotations
1 error and 11 warnings
checkstyle / checkstyle
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
|
checkstyle / checkstyle
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
checkstyle / checkstyle:
src/main/java/org/mvplugins/multiverse/core/MultiverseCore.java#L21
[checkstyle] reported by reviewdog 🐶
Unused import - org.bukkit.plugin.PluginManager.
Raw Output:
/github/workspace/./src/main/java/org/mvplugins/multiverse/core/MultiverseCore.java:21:8: warning: Unused import - org.bukkit.plugin.PluginManager. (com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck)
|
checkstyle / checkstyle:
src/main/java/org/mvplugins/multiverse/core/MultiverseCore.java#L213
[checkstyle] reported by reviewdog 🐶
'.' has incorrect indentation level 24, expected level should be 16.
Raw Output:
/github/workspace/./src/main/java/org/mvplugins/multiverse/core/MultiverseCore.java:213:25: warning: '.' has incorrect indentation level 24, expected level should be 16. (com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck)
|
checkstyle / checkstyle:
src/main/java/org/mvplugins/multiverse/core/inject/PluginServiceLocator.java#L13
[checkstyle] reported by reviewdog 🐶
'org.mvplugins.multiverse.core.inject.binder.PluginBinder' should be separated from previous imports.
Raw Output:
/github/workspace/./src/main/java/org/mvplugins/multiverse/core/inject/PluginServiceLocator.java:13:1: warning: 'org.mvplugins.multiverse.core.inject.binder.PluginBinder' should be separated from previous imports. (com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck)
|
checkstyle / checkstyle:
src/main/java/org/mvplugins/multiverse/core/inject/PluginServiceLocator.java#L15
[checkstyle] reported by reviewdog 🐶
Wrong order for 'java.lang.annotation.Annotation' import.
Raw Output:
/github/workspace/./src/main/java/org/mvplugins/multiverse/core/inject/PluginServiceLocator.java:15:1: warning: Wrong order for 'java.lang.annotation.Annotation' import. (com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck)
|
checkstyle / checkstyle:
src/main/java/org/mvplugins/multiverse/core/inject/PluginServiceLocator.java#L19
[checkstyle] reported by reviewdog 🐶
Missing a Javadoc comment.
Raw Output:
/github/workspace/./src/main/java/org/mvplugins/multiverse/core/inject/PluginServiceLocator.java:19:1: warning: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocTypeCheck)
|
checkstyle / checkstyle:
src/main/java/org/mvplugins/multiverse/core/inject/PluginServiceLocator.java#L29
[checkstyle] reported by reviewdog 🐶
Class 'PluginServiceLocator' looks like designed for extension (can be subclassed), but the method 'enable' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PluginServiceLocator' final or making the method 'enable' static/final/abstract/empty, or adding allowed annotation for the method.
Raw Output:
/github/workspace/./src/main/java/org/mvplugins/multiverse/core/inject/PluginServiceLocator.java:29:5: info: Class 'PluginServiceLocator' looks like designed for extension (can be subclassed), but the method 'enable' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PluginServiceLocator' final or making the method 'enable' static/final/abstract/empty, or adding allowed annotation for the method. (com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck)
|
checkstyle / checkstyle:
src/main/java/org/mvplugins/multiverse/core/inject/PluginServiceLocator.java#L29
[checkstyle] reported by reviewdog 🐶
Missing a Javadoc comment.
Raw Output:
/github/workspace/./src/main/java/org/mvplugins/multiverse/core/inject/PluginServiceLocator.java:29:5: warning: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck)
|
checkstyle / checkstyle:
src/main/java/org/mvplugins/multiverse/core/inject/PluginServiceLocator.java#L37
[checkstyle] reported by reviewdog 🐶
Class 'PluginServiceLocator' looks like designed for extension (can be subclassed), but the method 'disable' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PluginServiceLocator' final or making the method 'disable' static/final/abstract/empty, or adding allowed annotation for the method.
Raw Output:
/github/workspace/./src/main/java/org/mvplugins/multiverse/core/inject/PluginServiceLocator.java:37:5: info: Class 'PluginServiceLocator' looks like designed for extension (can be subclassed), but the method 'disable' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PluginServiceLocator' final or making the method 'disable' static/final/abstract/empty, or adding allowed annotation for the method. (com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck)
|
checkstyle / checkstyle:
src/main/java/org/mvplugins/multiverse/core/inject/PluginServiceLocator.java#L37
[checkstyle] reported by reviewdog 🐶
Missing a Javadoc comment.
Raw Output:
/github/workspace/./src/main/java/org/mvplugins/multiverse/core/inject/PluginServiceLocator.java:37:5: warning: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck)
|
checkstyle / checkstyle:
src/main/java/org/mvplugins/multiverse/core/inject/PluginServiceLocator.java#L57
[checkstyle] reported by reviewdog 🐶
')' should be on the previous line.
Raw Output:
/github/workspace/./src/main/java/org/mvplugins/multiverse/core/inject/PluginServiceLocator.java:57:21: warning: ')' should be on the previous line. (SeparatorWrapEol)
|