Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming the DAQ modules to improve clarity + added mu2e::EventHeader to the DataDecoders maker #1434

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gianipez
Copy link
Contributor

@gianipez gianipez commented Mar 8, 2025

  • renaming DAQ modules
  • added the mu2e::EventHeader (from artdaq-core-mu2e) as additional output of ProcessDTCAndCFOEvents module (we are developing the CFO_Event record that will be used to populate the EventHeader)

@FNALbuild
Copy link
Collaborator

Hi @gianipez,
You have proposed changes to files in these packages:

  • DAQ

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for d751a36: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Collaborator

☀️ The build tests passed at d751a36.

Test Result Details
test with Command did not list any other PRs to include
merge Merged d751a36 at 880127c
build (prof) Log file. Build time: 04 min 24 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file. Return Code 127.
check_cmake Log file. Return Code 1.
FIXME, TODO TODO (0) FIXME (0) in 7 files
clang-tidy 0 errors 0 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at d751a36 after being merged into the base branch at 880127c.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@gianipez
Copy link
Contributor Author

gianipez commented Mar 8, 2025

@FNALbuild run build test with Mu2e/mu2e-trig-config#68

@FNALbuild
Copy link
Collaborator

⌛ The following tests have been triggered for d751a36: build (Build queue is empty)

@gianipez
Copy link
Contributor Author

gianipez commented Mar 8, 2025

@gianipez
Copy link
Contributor Author

gianipez commented Mar 8, 2025

@FNALbuild run build test with Mu2e/mu2e-trig-config#68

@FNALbuild
Copy link
Collaborator

⌛ The following tests have been triggered for e39ac30: build (Build queue is empty)

@FNALbuild
Copy link
Collaborator

☔ The build tests failed for d751a36.

Test Result Details
test with Included Mu2e/mu2e-trig-config#68 @ b08c57c861fedcab23073001633d8294e0860610 by merge
merge Merged d751a36 at 880127c
build (prof) Log file. Build time: 04 min 23 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file. Return Code 1.
ceSteps Log file.
ceDigi Log file. Return Code 1.
muDauSteps Log file.
ceMix Log file. Return Code 1.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file. Return Code 127.
check_cmake Log file. Return Code 1.
FIXME, TODO TODO (0) FIXME (0) in 7 files
clang-tidy 0 errors 0 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at d751a36 after being merged into the base branch at 880127c.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@FNALbuild
Copy link
Collaborator

☔ The build tests failed for e39ac30.

Test Result Details
test with Included Mu2e/mu2e-trig-config#68 @ b08c57c861fedcab23073001633d8294e0860610 by merge
merge Merged e39ac30 at 880127c
build (prof) Log file. Build time: 04 min 25 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file. Return Code 1.
ceSteps Log file.
ceDigi Log file. Return Code 1.
muDauSteps Log file.
ceMix Log file. Return Code 1.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file. Return Code 127.
check_cmake Log file.
FIXME, TODO TODO (0) FIXME (0) in 7 files
clang-tidy 0 errors 0 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at e39ac30 after being merged into the base branch at 880127c.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@gianipez
Copy link
Contributor Author

gianipez commented Mar 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants