Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registered CRV mother volumes #1408

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

ehrlich-uva
Copy link
Contributor

Up until now, we used cut boxes around the CRV modules to create regions where certain cuts are applied. We would like to move away from this approach as it is difficult to maintain for different setups (full geometry, KPP, Wideband). The first step was the Production PR 393 which was just merged. The next step will be to apply smaller minimum range cuts to all CRV sectors. We would like to use the minRangeRegionCuts setting for this purpose. However, this setting requires, that the mother volumes of the CRV sectors are added to the Mu2eG4Helper. This is currently not the case, because the volumes of the CRV were constructed using basic Geant4 functions and not Offline's nestBox, nestTubs, ... functions. These nest functions add the volumes to the Mu2eG4Helper. This PR makes a small change to the construction of the CRV by adding the CRV mother volumes to the Mu2eG4Helper. The result has been tested by applying a much smaller minRangeRegionCuts to the CRV sectors. The picture below shows that the cosmic ray muon has no secondaries outside the CRV, but produces many small tracks inside the CRV (including the scintillator counters, aluminum sheets and strong back).
image

@FNALbuild
Copy link
Collaborator

Hi @ehrlich-uva,
You have proposed changes to files in these packages:

  • Mu2eG4
  • CRVReco

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

The following users requested to be notified about changes to these packages:
@resnegfk

⌛ The following tests have been triggered for 6e69b8c: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Collaborator

☀️ The build tests passed at 6e69b8c.

Test Result Details
test with Command did not list any other PRs to include
merge Merged 6e69b8c at e1260f8
build (prof) Log file. Build time: 04 min 21 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file.
FIXME, TODO 🔶 TODO (1) FIXME (1) in 2 files
clang-tidy 🔶 0 errors 82 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 6e69b8c after being merged into the base branch at e1260f8.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it have to be hard coded?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but I think it's good enough for now.

@ehrlich-uva
Copy link
Contributor Author

@brownd1978 This change will slightly change the simulation. Therefore, this PR should be merged as the only PR of the day so that we can see its impact in the nightly validations.

@FNALbuild
Copy link
Collaborator

📝 The HEAD of main has changed to cbc77f2. Tests are now out of date.

@brownd1978 brownd1978 merged commit 21a5060 into Mu2e:main Feb 6, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants