feat: Add new chunk count column for tracking #342
+454
−324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… index and lenght of columns
TDemeco
approved these changes
Feb 5, 2025
client/file-manager/src/rocksdb.rs
Outdated
| @@ -20,23 +20,50 @@ use crate::{ | |||
| LOG_TARGET, | |||
| }; | |||
| use codec::{Decode, Encode}; | |||
| use strum::{EnumCount, VariantArray}; | |||
|
|
|||
| #[derive(Debug, Clone, Copy, EnumCount, VariantArray)] | |||
|
|
||
| #[derive(Debug, Clone, Copy, EnumCount, VariantArray)] | ||
| pub enum Column { | ||
| Metadata, |
There was a problem hiding this comment.
We should have docs for the Metadata member as well, and if possible for all the columns
| @@ -58,7 +85,8 @@ fn open_or_creating_rocksdb(db_path: String) -> io::Result<kvdb_rocksdb::Databas | |||
| Ok(db) | |||
| } | |||
|
|
|||
| /// Storage backend for RocksDB. | |||
| /// Storage backend implementation for RocksDB. | |||
There was a problem hiding this comment.
Love the improved docs on all functions!
| @@ -46,7 +73,7 @@ fn open_or_creating_rocksdb(db_path: String) -> io::Result<kvdb_rocksdb::Databas | |||
| path.push(db_path.as_str()); | |||
| path.push("storagehub/file_storage/"); | |||
|
|
|||
| let db_config = kvdb_rocksdb::DatabaseConfig::with_columns(8); | |||
| let db_config = kvdb_rocksdb::DatabaseConfig::with_columns(NUMBER_OF_COLUMNS); | |||
There was a problem hiding this comment.
Nice improvement.
Indeed in the past I had errors when forgetting to increase the columns number hardcoded value. It would avoid it in the future.
undercover-cactus
approved these changes
Feb 6, 2025
links234
requested changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new
CHUNK_COUNT_COLUMNto track number of chunks for a given file key. This avoids having to iterate through the entire file trie to count all the chunks and conclude if we have uploaded all the chunks yet for a file.These changes also include a refactor of our column definitions to have consistent index retrievals and column length constant. In addition, I added some documentation to these columns to have a clear definition for their purpose in the context of RocksDB file storage.
Resolves issue #20