Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add verifier methods #3

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Feature: add verifier methods #3

merged 1 commit into from
Feb 15, 2024

Conversation

odesenfans
Copy link
Contributor

Problems:

  • there is no sync implementation of the verifier functions
  • the verifier functions are located in the prover module.

Solution:

  1. Create a verifier module
  2. Add sync implementations of the verifier functions. There are now 3x2 (sync + async) verifier methods:
    • run_verifier_from_command_line: thin wrapper around cpu_air_verifier
    • run_verifier: verify a proof file
    • run_verifier_with_annotations: verify a proof file and generate annotations.

Problems:
* there is no sync implementation of the verifier functions
* the verifier functions are located in the prover module.

Solution:
1. Create a verifier module
2. Add sync implementations of the verifier functions. There are now
   3x2 (sync + async) verifier methods:
   * `run_verifier_from_command_line`: thin wrapper around
     `cpu_air_verifier`
   * `run_verifier`: verify a proof file
   * `run_verifier_with_annotations`: verify a proof file and generate
     annotations.
@odesenfans odesenfans requested a review from notlesh February 15, 2024 13:06
@odesenfans odesenfans assigned odesenfans and notlesh and unassigned odesenfans Feb 15, 2024
@odesenfans odesenfans merged commit d4111ae into main Feb 15, 2024
1 check passed
@odesenfans odesenfans deleted the od/verifier-functions branch February 15, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants