Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 修复Notice在Tabbar页面时跳转至其他页面导致播放异常的问题并提供reset方法 #680

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

Moonofweisheng
Copy link
Owner

@Moonofweisheng Moonofweisheng commented Oct 24, 2024

Closes: #358 #650

🤔 这个 PR 的性质是?(至少选择一个)

  • 日常 bug 修复
  • 新特性提交
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • CI/CD 改进
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

#358 #650

💡 需求背景和解决方案

问题背景:

  1. 当前使用transition实现Noticebar的播放动画,动画开始时会使用uni.createSelectorQuery查询节点信息。
  2. 当前实现了功能:多行水平轮播。
  3. onActivated生命周期仅在H5端支持(uni-app文档中标示App也支持,不过实测不支持)。

以上导致没有很好的办法解决此问题,故在H5端使用onActivated钩子重置动画,并对外提供了reset方法,用于重置动画。

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充

Summary by CodeRabbit

  • 新功能

    • 添加了重置播放动画的方法,用户可以通过按钮重置wd-notice-bar组件的动画。
    • 更新了文档,包含重置方法的使用示例和详细说明。
  • 文档

    • 更新了wd-notice-bar组件的文档,增加了关于重置播放动画的新章节和示例。
  • 改进

    • 优化了组件的生命周期管理和过渡状态处理,提高了组件的稳定性和可维护性。

Copy link

coderabbitai bot commented Oct 24, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

此次更改主要集中在 wd-notice-bar 组件的文档和实现上。文档中新增了“重置播放动画”部分,介绍了如何使用 reset 方法重置通知栏的播放动画。实现方面,在 Index.vue 中添加了新的演示块和按钮以触发重置功能,同时更新了类型定义以支持新方法。样式文件中移除了与动画相关的混合和关键帧,以简化组件的动画处理。

Changes

文件路径 更改摘要
docs/component/notice-bar.md 添加“重置播放动画”部分,新增 reset 方法的文档及示例。
src/pages/noticeBar/Index.vue 新增演示块和按钮以重置 wd-notice-bar 动画,添加 handleReset 方法和类型导入。
src/uni_modules/wot-design-uni/components/wd-notice-bar/index.scss 移除与动画相关的混合和关键帧。
src/uni_modules/wot-design-uni/components/wd-notice-bar/types.ts 添加新的类型定义 NoticeBarPropsNoticeBarExposeNoticeBarInstance
src/uni_modules/wot-design-uni/components/wd-notice-bar/wd-notice-bar.vue 添加生命周期钩子和 reset 方法,更新动画处理逻辑,改进错误处理。

Assessment against linked issues

Objective Addressed Explanation
确保在返回缓存页面时通知仍可播放 (#358)

Suggested reviewers

  • 810505339

Poem

🐇 在草地上跳跃,欢快无比,
通知栏重置,动画如新,
点击按钮,重放轻盈,
兔子欢呼,乐在其中!
让我们一起,享受这变化,
动画流畅,心情愉悦! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wot-design-uni ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 1:50pm

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for wot-design-uni ready!

Name Link
🔨 Latest commit de0f058
🔍 Latest deploy log https://app.netlify.com/sites/wot-design-uni/deploys/671a50bc0b75be0008b82661
😎 Deploy Preview https://deploy-preview-680--wot-design-uni.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant