refactor: Rename definitions identifier class

- `ObjectHashIdentifier` is misleading since definitions are now identified by their Fully Qualified Name (FQN)
MontealegreLuis · Apr 26, 2022 · 7158b92 · 7158b92
1 parent b654bd9
commit 7158b92
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/Code/Definition.php b/src/Code/Definition.php
@@ -9,16 +9,15 @@
 
 use PhUml\Code\Methods\Method;
 use PhUml\Code\Modifiers\Visibility;
+use PhUml\Graphviz\FQNIdentifier;
 use PhUml\Graphviz\HasNodeIdentifier;
-use PhUml\Graphviz\ObjectHashIdentifier;
 
 /**
  * Base class for interfaces, classes and traits
  */
 abstract class Definition implements Named, HasNodeIdentifier
 {
-    use WithName;
-    use ObjectHashIdentifier;
+    use FQNIdentifier;
 
     /** @var Method[] */
     protected array $methods;

diff --git a/src/Graphviz/ObjectHashIdentifier.php → src/Graphviz/FQNIdentifier.php b/src/Graphviz/ObjectHashIdentifier.php → src/Graphviz/FQNIdentifier.php
@@ -10,9 +10,11 @@
 use PhUml\Code\WithName;
 
 /**
- * Both `ClassDefinition` and `InterfaceDefinition` objects identifiers are generated using their Fully Qualified Name
+ * `Definition`s are required to have unique identifiers, so we can determine relationships between them
+ *
+ * Definitions identifiers are generated using their Fully Qualified Name (FQN)
  */
-trait ObjectHashIdentifier
+trait FQNIdentifier
 {
     use WithName;