Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blades equipped to a void cloak having visible sprites #5305

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

Absolucy
Copy link
Member

@Absolucy Absolucy commented Feb 6, 2025

About The Pull Request

Ports tgstation/tgstation#89343, and my follow-up fix tgstation/tgstation#89373

This adds a new item trait, TRAIT_NO_WORN_ICON, which is exactly what it says on the tin - the worn overlay for said item will not be added when the trait is present, so we give it to items hidden by the hood.

I also refactored the EXAMINE_SKIP item flag into TRAIT_EXAMINE_SKIP.

Why It's Good For The Game

stealth thing having an obvious sprite tell is bad. bugfix good.

Changelog

🆑
fix: Void Cloaks now properly hide blades and such in the suit storage from the wearer's sprite.
/:cl:

@Absolucy Absolucy added the Fix fix da bug label Feb 6, 2025
@Absolucy Absolucy merged commit fadb2d1 into Monkestation:master Feb 7, 2025
27 checks passed
@Absolucy Absolucy deleted the void-cloak-fix branch February 7, 2025 07:34
github-actions bot added a commit that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix fix da bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant