Optimizes /proc/icon_exists
#5287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Credit to @Kapu1178
Absolucy
added
the
Performance / Optimization
|
You'll probably want to modularize this, or mark it with |
|
@LikeLakers2 said PR was closed due to being stale, and I plan to try to upstream this again I'll draft this for now while I try to re-upstream it. |
|
@Absolucy Since my PR (which just got merged) diverged from yours quite a bit, I don't know whether you want to try pulling in the changes, or if you want me to make my own port PR. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
/proc/icon_existsis actually quite a hot proc, to the point where it shows up when sorting profiles by overtime, and, and kapu posted this quite simple optimization regarding caching on coderbusCredit to @Kapu1178
Why It's Good For The Game
faster code is good meow
Changelog
no player-facing changes