Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer the asteroid magnet's initial map generation to LateInitialize #5237

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

Absolucy
Copy link
Member

@Absolucy Absolucy commented Feb 1, 2025

About The Pull Request

Fixes #5234

LateInitialize is the proper place for this, as maploading in Initialize leads to problems, and LateInitialize sets waitfor = FALSE anyways

Why It's Good For The Game

more reliable code

Changelog

no player-facing changes

@Absolucy Absolucy added the Fix fix da bug label Feb 1, 2025
@tired-wired tired-wired merged commit 7cc446c into Monkestation:master Feb 2, 2025
27 checks passed
@Absolucy Absolucy deleted the asteroid-magnet-lateload branch February 2, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix fix da bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test create_and_destroy: /obj/machinery/asteroid_magnet slept during Initialize()
2 participants