-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BOUNTY][PORT] Corporate Judo Port #4468
Open
Coll6
wants to merge
47
commits into
Monkestation:master
Choose a base branch
from
Coll6:Corp-Judo
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+315
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into Corp-Judo
@Coll6 linters go brr but we codefreezing until january is over |
DGamerL
suggested changes
Dec 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a link to the original PR!
Edit: I can't read
DGamerL
approved these changes
Jan 3, 2025
I don't really see myself finishing this without a good reason. I'll close this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Paradise Station Original Corporate Judo PR: ParadiseSS13/Paradise#21229
Ports over Corporate Judo from Paradise Station. A combo fighting move martial art given when wearing the Judo belt. Corporate Judo relies on unarmed combos of combat intents to activate special moves. Each special move focusing on knocking down and exhausting the opponent till they are unable to resist apprehension.
For the most part this is a direct port. There is some slight differences to feel and how status effects are applied but otherwise a direct port in that regard.
The big changes are mostly how combos work. Previously you had a time limit to complete a move say 5-6 seconds. This is one time limit for any move this include Golden Blast making it really difficult to impossible to pull off. Especially considering what it does seems silly. Also messing up a combo and other interactions felt wrong or stifled you just got reset and had to start over. Here is how it works now.
You have a 2.5s timer once you start a combo. Every time you continue a valid combo on the same target the timer will refresh. A valid combo is anything that your current moves can build into and try to execute one of Judo's abilities. If your next hit does not result in building a valid combo you will be reset but your combo ending move will be carried over. This will allow you to break out of combos should the situation call for a change from what you were building or let you flow from your mistake into an actual combo. If your move continues a combo of course you get a refresh of the timer. This will make things like Golden Blast potentially possible. It will punish people who end up staying in fights with a judo user longer period but the short timer to refresh will allow potential escaping and punishing the Judo user.
Because of how I changed this combo pathing system it had some interesting consequences. One move can now just flow into another move if you wish. Currently only Armbar into Wheel Throw exhibit this behavior. It no longer uses some kind of status effect or activation. You just flow Armbar into Wheel Throw as if you were just chaining any other combo. Of course your time limit will continue to count down and refresh as normal. Another consequence is being able to define one ability to have multiple combo paths. So in theory you could Have your normal Judo Throw combo but also put Judo Throw in the middle of Golden Blasts combo all with just an edit of a line. This could lead to some interesting changes in the future. We dont need to stick to just these moves. We can add more add longer chains even add minor crowd control or debuffs for reaching certain points in a combo.
Why It's Good For The Game
Note: I do not fight, play antag roles or the such. So I'll do my best as the given explanations weren't sufficient
Corporate Hands down is just going to be a pain. While the code is setup and easily changed balancing it with the systems we have now is going to be a process. Here is how I see things going on during shifts. It's either stun batons, guns, or bombs. If you look at these options you have quite a list of guns and different chems mixtures and just tools to explode things. When it comes to nonlethals, I have always ever just seen the baton. Judo has the potential to add an interesting and fun form of nonlethal if just tweaked right.
Pros
Encourages More Tactical Play
By introducing a martial art that emphasizes grappling and throwing over traditional baton use, Corporate Judo would encourage more skillful, strategic gameplay from security officers. It rewards good positioning, timing, and the ability to anticipate and counter an opponent's movements, rather than just relying on the baton. Much harder to stop an enemy when you have to combo into them on the move. But much more satisfying when you nail the combo blocking off key exits and quick timing.
Non-Lethal Playstyle
Since Corporate Judo focuses on incapacitating enemies without the use of lethal force, it creates a more diverse, non-lethal approach to handling suspects. This could lead to a more nuanced approach in situations where security needs to subdue a criminal or disrupt a riot but without the risk of fatality, fostering a more dynamic, less deadly security department.
Promotes Roleplay
The introduction of a specialized martial art can create more opportunities for interesting roleplay. Officers trained in Corporate Judo could interact with suspects in ways that are both humorous and professional, showing off their skills in non-lethal takedowns. Let's be honest there are those on here who want to act like a Judo master. In my mind I can imagine sec and antags fighting in the hall like one of those old kung fu movies. This is a bigger prospect on MRP than LRP
Balance to Baton Use
A restriction on baton use might curb the over-reliance on batons for subduing criminals, which has been a common criticism in SS13. Security officers might have to rely on their wits and skills, rather than just baton-spamming, making confrontations more interesting. If anything at the very least adds another nonlethal way to take down an adversary while lowering the risk of others getting caught in the cross fire.
Cons
Balance Issues
If Corporate Judo is too effective, it might make baton use seem obsolete, causing balance issues. Security officers might opt for Corporate Judo exclusively, creating frustration for antagonists or players who wish to resist arrest. On the other hand, if it's too weak, it might not be taken seriously as a viable option, making it irrelevant.
Potential for Overpowered Abilities
If the martial art allows for very easy takedowns or counters, especially against armed or untrained opponents, it could create a situation where security officers can completely overpower criminals, even if they are armed. This could reduce the variety and excitement of confrontations, making them too one-sided. We have already had to add in a couple of nerfs to lower chances of perma-stuns. Things like shove stun + Judo Combo's might be extremely unfun on the receiving end.
In Conclusion:
Introducing Corporate Judo could be a fun way to encourage security officers to approach law enforcement and self-defense in a more creative and non-lethal way. It could add depth and strategic variety to security playstyles, offer opportunities for interesting roleplay, and curb the over-reliance on batons for subduing criminals. However, careful balancing would be necessary to avoid making it overpowered or frustrating for other players. With proper implementation, it could be a fun and dynamic addition to SS13's complex interactions.
Changelog
🆑Siro
add: Corporate Judo Martial Art
add: Judo moves Discombobulate, Judo Throw, Eye Poke, Armbar, Wheel Throw, Golden Blast + Associated teachings menu
add: Judo Belt
code: no weapon status effect blocks using certain items and weapons from being used.
image: Added Judo belt hand, equip, and object icons
sound: Added Golden Blast voice line
code: Adapted Judo to monkestation martial art system
balance: Increased Stamina damage for monkestation Discombobulate(10 to 25), Judo Throw(25 to 62), Armbar(45 to 112), Wheel Throw(120 to 250), Golden Blast(120 to 250)
balance: Combo timer refreshes for every successful combo addition.
balance: 12 combo max limit and 2.5 second combo timer.
/:cl: