Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder renders for blocks, change some textures #55

Merged
merged 18 commits into from
Nov 18, 2024

Conversation

sisby-folk
Copy link

@sisby-folk sisby-folk commented Nov 16, 2024

Closes #41

Adds placeholders that render whenever a block is empty, or the player is holding a glowcase item and isn't targeting the block.

Also changes the texture and render style of hyperlink and popup blocks to match - they're now larger, permanently fullbright, white with a shadow, and 16x16 instead of 32x32. Plus i swapped the sprite block to be a star texture.

image

java_5rtRrZx8Gf.mp4

Finally, I've reordered the creative tab as displays, player interactions, items.

image

@sisby-folk sisby-folk marked this pull request as ready for review November 17, 2024 01:48
@sisby-folk sisby-folk changed the title Add placeholder renders for blocks Add placeholder renders for blocks, change some textures Nov 17, 2024
@sisby-folk
Copy link
Author

Ready for review again!

image

image

interactable blocks are now half size, hyperlink and sprite have new textures, stuff is no longer backwards, and titles render.

also, if for some reason the player hovers over a placeholder and it doesn't dissappear (e.g. it's a hyperlink block, or it's "empty" e.g. a text block with no text) the placeholder will tint. this makes text readable and makes it feel a lil more dynamic.

Copy link

@Chailotl Chailotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I like the clean up and reorganization you did

Although non-blocking, I think the placeholder renders should be billboarded

@sisby-folk
Copy link
Author

sisby-folk commented Nov 17, 2024

thanks! I reckon disagree on the bilboarding though - I think we can billboard anything that doesn't have a rotation block property, but the ones that do should be as-is so you can see which way around the block is facing even without content / fixed settings enabled.

@sisby-folk
Copy link
Author

Blocks without rotation now bilboard to indicate they have no rotation. back faces of blocks with rotation are now darkened (easier to see than noticing the texture is backwards)

image

@sisby-folk sisby-folk merged commit ad71496 into ModFest:1.21 Nov 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display item model of invisible blocks when holding a glowcase block
2 participants