Skip to content

Commit

Permalink
update github workflows and readme
Browse files Browse the repository at this point in the history
  • Loading branch information
davidgamez committed Apr 19, 2024
1 parent d535c9d commit 2e27a29
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/api-deployer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ on:
type: string

env:
python_version: '3.10'
python_version: '3.11'
java_version: '11' # needed by setup-openapi-generator.sh
local_postgres_db: postgres_db
local_postgres_user: postgres_user
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
workflow_call:

env:
python_version: '3.10'
python_version: '3.11'
java_version: '11' # needed by setup-openapi-generator.sh

jobs:
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/db-update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ on:
description: GCP region
required: true
type: string

env:
python_version: '3.11'

jobs:
db-schema-update:
name: 'Database Schema Update'
Expand Down Expand Up @@ -136,7 +140,7 @@ jobs:
- name: Setup python
uses: actions/setup-python@v4
with:
python-version: '3.10'
python-version: ${{ env.python_version }}

- name: Authenticate to Google Cloud QA/PROD
uses: google-github-actions/auth@v2
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ on:
required: true
description: 'Refresh token for API authentication'

env:
python_version: '3.11'

jobs:
integration-tests:
Expand All @@ -27,7 +29,7 @@ jobs:
- name: Set up Python 3.10
uses: actions/setup-python@v4
with:
python-version: '3.10'
python-version: ${{ env.python_version }}

- name: Download csv version of the database
run: wget -O sources.csv https://bit.ly/catalogs-csv
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/schedule-load-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ env:
LOCUST_USERS: 100
LOCUST_RATE: 10
LOCUST_DURATION: 180
python_version: '3.11'

jobs:
load-test:
Expand All @@ -23,7 +24,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: "3.x"
python-version: ${{ env.python_version }}

- name: Install dependencies
run: |
Expand Down
13 changes: 4 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,17 +59,12 @@ Folder `api` contains source code of the API implementation. This repository rel

## Requirements.

Python <= 3.10
Python == 3.11

### Python 3.11 incompatibility notice
### Scripts dependencies

This project uses [sqlacodegen](https://github.com/agronholm/sqlacodegen) to generate ORM models. This project is also depending on [SqlAlchemy]https://www.sqlalchemy.org/. This combination od dependencies doesn't support **yet**(August 2023) Python 3.11 due to [bpo-45320](https://github.com/python/cpython/issues/89483).

Related issues:

- [bpo-45320](https://github.com/python/cpython/issues/89483)
- [sqlacodegen failing with Error: import name 'ArgSpec' from 'inspect'](https://github.com/agronholm/sqlacodegen/issues/239)
- [fix function name in codegen.py for python v3.11](https://github.com/agronholm/sqlacodegen/issues/274)
- docker
- wget

## Installation & Usage

Expand Down

0 comments on commit 2e27a29

Please sign in to comment.