Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1927 flex geo json parsing failed #1947

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

qcdyx
Copy link
Contributor

@qcdyx qcdyx commented Jan 24, 2025

Summary:
Closes #1927

Expected behavior:
Added message fields to both MalformedJsonNotice and UnsupportedGeoJsonTypeNotice which already covered geojson parsing failed.
image

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@qcdyx qcdyx linked an issue Jan 24, 2025 that may be closed by this pull request
Copy link
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

@qcdyx qcdyx requested a review from emmambd January 24, 2025 16:19
Copy link
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit ee877d8
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1792 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1792 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1792 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1792 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1792 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 3.67 3.77 ⬆️+0.10
Median -- 1.32 1.41 ⬆️+0.09
Standard Deviation -- 10.71 10.63 ⬇️-0.08
Minimum in References Reports ar-buenos-aires-subterraneos-de-buenos-aires-subte-gtfs-6 0.48 0.61 ⬆️+0.14
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 281.80 277.72 ⬇️-4.08
Minimum in Latest Reports us-california-city-of-wasco-gtfs-1788 0.48 0.48 ⬆️+0.01
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 281.80 277.72 ⬇️-4.08
📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 454.75 MiB 466.07 MiB ⬆️+11.32 MiB
Median -- 331.92 MiB 331.92 MiB ⬇️0 bytes
Standard Deviation -- 710.39 MiB 761.83 MiB ⬆️+51.44 MiB
Minimum in References Reports ro-vrancea-consiliul-judetean-vrancea-gtfs-1984 39.98 MiB 40.02 MiB ⬆️+32.00 KiB
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 10.51 GiB 10.57 GiB ⬆️+64.28 MiB
Minimum in Latest Reports us-california-thousand-oaks-transit-gtfs-33 53.96 MiB 39.16 MiB ⬇️-14.80 MiB
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 10.51 GiB 10.57 GiB ⬆️+64.28 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flex: geo_json_parsing_failed
1 participant