Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 1820 flex missing stop times record #1945

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat: 1820 flex missing stop times record #1945

wants to merge 7 commits into from

Conversation

qcdyx
Copy link
Contributor

@qcdyx qcdyx commented Jan 22, 2025 •
edited
Loading

Summary:
Closes #1820

Expected behavior:

image

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@qcdyx qcdyx linked an issue Jan 22, 2025 that may be closed by this pull request
Flex: missing_stop_times_record #1820
Open
@qcdyx qcdyx requested a review from tzujenchanmbd January 22, 2025 20:50
@github-actions GitHub Actions
Copy link
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

@github-actions GitHub Actions
Copy link
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 1630432
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1792 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1792 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1792 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1792 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1792 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 3.62 3.69 ⬆️+0.07
Median -- 1.33 1.38 ⬆️+0.04
Standard Deviation -- 10.42 10.41 ⬇️-0.01
Minimum in References Reports ph-unknown-hm-transport-inc-and-robinsons-malls-gtfs-1105 0.45 0.52 ⬆️+0.06
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 283.08 276.78 ⬇️-6.30
Minimum in Latest Reports us-massachusetts-massachusetts-area-express-max-gtfs-431 0.48 0.49 ⬆️+0.01
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 283.08 276.78 ⬇️-6.30
📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 458.54 MiB 465.20 MiB ⬆️+6.66 MiB
Median -- 333.92 MiB 331.92 MiB ⬇️-2.00 MiB
Standard Deviation -- 729.17 MiB 772.46 MiB ⬆️+43.29 MiB
Minimum in References Reports mexico-jalisco-direccion-general-de-transporte-publico-de-puerto-vallarta-gtfs-2034 38.56 MiB 399.92 MiB ⬆️+361.36 MiB
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 10.44 GiB 10.91 GiB ⬆️+484.49 MiB
Minimum in Latest Reports ro-vrancea-consiliul-judetean-vrancea-gtfs-1984 40.02 MiB 38.20 MiB ⬇️-1.82 MiB
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 10.44 GiB 10.91 GiB ⬆️+484.49 MiB

@emmambd
Copy link
Contributor

emmambd commented Jan 22, 2025

@qcdyx I think we should add the location_id or location_group_id associated with the trip. cc @tzujenchanmbd for thoughts?

Should be able to use the same dynamic logic as was introduced in #1935

@tzujenchanmbd
Copy link

Agree @emmambd it would be great to see the ids.

@github-actions GitHub Actions
Copy link
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

@github-actions GitHub Actions
Copy link
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit b491d59
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1792 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1792 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1792 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1792 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1792 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 3.65 3.78 ⬆️+0.13
Median -- 1.33 1.42 ⬆️+0.09
Standard Deviation -- 10.43 10.45 ⬆️+0.02
Minimum in References Reports us-michigan-detroit-people-mover-gtfs-417 0.46 0.57 ⬆️+0.10
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 279.05 274.16 ⬇️-4.89
Minimum in Latest Reports us-california-city-of-wasco-gtfs-1788 0.48 0.52 ⬆️+0.04
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 279.05 274.16 ⬇️-4.89
📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 459.22 MiB 456.83 MiB ⬇️-2.39 MiB
Median -- 331.92 MiB 332.23 MiB ⬆️+319.05 KiB
Standard Deviation -- 745.75 MiB 732.69 MiB ⬇️-13.05 MiB
Minimum in References Reports us-colorado-san-miguel-county-gtfs-2195 39.10 MiB 47.84 MiB ⬆️+8.74 MiB
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 10.73 GiB 10.60 GiB ⬇️-132.04 MiB
Minimum in Latest Reports ro-vrancea-consiliul-judetean-vrancea-gtfs-1984 68.70 MiB 38.19 MiB ⬇️-30.51 MiB
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 10.73 GiB 10.60 GiB ⬇️-132.04 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzujenchanmbd tzujenchanmbd Awaiting requested review from tzujenchanmbd

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flex: missing_stop_times_record
3 participants
@qcdyx @emmambd @tzujenchanmbd