improved nodejs codegen build and fixed race condition with update_ge… #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodejs
codegen build up to par with thegolang
codegen buildnodejs
codegen, I actually happened upon a bug in thegolang
implementation.docker run -d
backgrounds the entire docker container, which means that there is no guarantee that the code gen has completed prior to attempting the subsequentdocker cp
command. In addition, the container doesn't stay alive unless its foreground process stays alive. To solve for these race conditions, we override the container's original foreground process withtail -f > /dev/null
so that it will be around until we kill it and thenexec
the code gen command synchronously prior tocp
ing it. With both thegolang
and thepython
bindings, I never ran into this issue because the codegen was performant enough not to run into the race condition (not so fornodejs
😉 )