fix(error): Incorrect IsErrorNotFound behaviour

Return value instead of pointer in `NewErrorNotFound` that caused `IsErrorNotFound` to return false when expecting true. Signed-off-by: Maximilian Blatt <[email protected]>
MisterMX · Feb 14, 2024 · b57d73c · b57d73c
1 parent c50d6f1
commit b57d73c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/error.go b/error.go
@@ -11,7 +11,7 @@ type errNotFound struct {
 }
 
 func NewErrorNotFound(name string) error {
-	return &errNotFound{name: name}
+	return errNotFound{name: name}
 }
 
 func (e errNotFound) Error() string {

diff --git a/error_test.go b/error_test.go
@@ -19,7 +19,15 @@ func TestIsErrorNotFound(t *testing.T) {
 	}{
 		"ExpectTrue": {
 			args: args{
-				err: errNotFound{},
+				err: NewErrorNotFound("not-found"),
+			},
+			want: want{
+				isNotFound: true,
+			},
+		},
+		"ExpectWrappedTrue": {
+			args: args{
+				err: errors.Wrap(NewErrorNotFound("not-found"), "wrap"),
 			},
 			want: want{
 				isNotFound: true,