Fix NPE for "value" instances and optional fields #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all offsets to a dedicates
Span
class and removeoffset
, that should be represent offset of substream in a parent stream. This generally does not work, because Kaitai Struct has ability to set any IO stream for an instance. The proper fix should be on the generator and runtime size -- kaitai-io/kaitai_struct_java_runtime#26.Introduce a
getSpan()
method for a node, which could returnnull
in case of@pfroud, FYI