MKMPT-20 Caching mechanism to store data in local DB from API #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neteinstein
reviewed
Jun 7, 2024
build.gradle.kts
Outdated
| @@ -42,7 +42,7 @@ buildscript { | |||
| } | |||
| } | |||
| dependencies { | |||
| classpath(libs.sqldelight.plugin) | |||
| // classpath(libs.sqldelight.plugin) | |||
neteinstein
reviewed
Jun 7, 2024
| implementation(libs.ktor.logging) | ||
| implementation(libs.ktor.serialization) | ||
| implementation(libs.kotlinx.serialization) | ||
| implementation(projects.features.currencyexchange.data.remote.mindera.rest.schema) |
There was a problem hiding this comment.
formatting I hope I did it right
neteinstein
reviewed
Jun 7, 2024
| import app.cash.sqldelight.db.SqlDriver | ||
| import app.cash.sqldelight.driver.native.NativeSqliteDriver | ||
| import com.mindera.currencyexchange.database.AppDatabase | ||
| // |
neteinstein
reviewed
Jun 7, 2024
| @@ -22,7 +22,9 @@ kotlin { | |||
| implementation(libs.kotlinx.coroutines.core) | |||
| implementation(libs.kotlinx.datetime) | |||
| implementation(projects.common.coroutinesKtx) | |||
| implementation(projects.common.domain) } | |||
| implementation(projects.common.domain) | |||
| implementation(projects.features.currencyexchange.data.remote.mindera.rest.schema) | |||
There was a problem hiding this comment.
formatting I hope I did it right
djrsousa
reviewed
Jun 7, 2024
Comment on lines
35
to
40
| implementation( | ||
| projects.features.currencyexchange.data.remote.mindera.rest.schema | ||
| ) | ||
| implementation( | ||
| projects.features.currencyexchange.data.remote.mindera.rest.sample | ||
| ) |
There was a problem hiding this comment.
Suggested change
| implementation( | |
| projects.features.currencyexchange.data.remote.mindera.rest.schema | |
| ) | |
| implementation( | |
| projects.features.currencyexchange.data.remote.mindera.rest.sample | |
| ) | |
| implementation(projects.features.currencyexchange.data.remote.mindera.rest.schema) | |
| implementation(projects.features.currencyexchange.data.remote.mindera.rest.sample) |
gradle/libs.versions.toml
Outdated
Comment on lines
79
to
80
|
|
||
|
|
There was a problem hiding this comment.
Comment on lines
11
to
17
|
|
||
|
|
||
| suspend fun getAllCurrencies(): List<DomainCurrencyExchangeResponseItem> | ||
|
|
||
| suspend fun removeAllCurrencies() | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| suspend fun getAllCurrencies(): List<DomainCurrencyExchangeResponseItem> | |
| suspend fun removeAllCurrencies() | |
| suspend fun getAllCurrencies(): List<DomainCurrencyExchangeResponseItem> | |
| suspend fun removeAllCurrencies() |
There was a problem hiding this comment.
Comment on lines
26
to
28
| implementation( | ||
| projects.features.currencyexchange.data.remote.mindera.rest.schema | ||
| ) |
There was a problem hiding this comment.
Suggested change
| implementation( | |
| projects.features.currencyexchange.data.remote.mindera.rest.schema | |
| ) | |
| implementation(projects.features.currencyexchange.data.remote.mindera.rest.schema) |
build.gradle.kts
Outdated
| @@ -42,7 +42,6 @@ buildscript { | |||
| } | |||
| } | |||
| dependencies { | |||
| classpath(libs.sqldelight.plugin) | |||
| classpath("com.mikepenz.aboutlibraries.plugin:aboutlibraries-plugin:11.1.3") | |||
There was a problem hiding this comment.
| implementation(projects.common.domain) } | ||
| implementation(projects.common.domain) | ||
| implementation(projects.features.currencyexchange.data.remote.mindera.rest.schema) | ||
| } |
There was a problem hiding this comment.
I might be wrong but the indentation seems weird to me 😅 seems like the curly bracket is not aligned with the dependencies
There was a problem hiding this comment.
It's aliged. Please check the image
| suspend fun getCurrencyExchange(endpoint: String): List<DomainCurrencyExchangeResponseItem> | ||
|
|
||
| fun insertCurrency(currency: CurrencyExchangeResponseItem) | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA-Ticket
Added SQLDelight to store data
video.webm