Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: new FAQs from the ZK Hack #731

Merged
merged 3 commits into from
Nov 17, 2023
Merged

docs: new FAQs from the ZK Hack #731

merged 3 commits into from
Nov 17, 2023

Conversation

barriebyron
Copy link
Contributor

Closes: #730

Adds FAQs that came up during zkHack 2023

Question: do we want to include the Mina Protocol FAQs in this doc?

@barriebyron barriebyron added the docs Improvements or additions to documentation label Nov 16, 2023
@barriebyron barriebyron self-assigned this Nov 16, 2023
@barriebyron barriebyron requested a review from a team as a code owner November 16, 2023 19:07
Copy link

vercel bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 2:58pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
07-oracles ⬜️ Ignored (Inspect) Visit Preview Nov 17, 2023 2:58pm

- The first line of code executes before the proof is generated.
- The second line of code creates a precondition that is checked when the proof is sent to the blockchain to be verified.

This ensures that the transaction fails if the value of the field in question has changed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this another way of saying that that this addresses race conditions vulnerabilities? @jackryanservia @LucidSamuel


Yes, just pass in the appropriate BigInt literal.

`Field(0x1337)`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious about the context of this question, why wouldn't this be possible in the first place? @jackryanservia @LucidSamuel

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's likely a matter of developer familiarity. When using a new tool, developers often seek clarity, just to be sure, especially in case there are differences in how things work.

@iregina
Copy link
Contributor

iregina commented Nov 17, 2023

Left some comments - overall, it looks good just had one question about the Field type questions.

```

- The first line of code executes before the proof is generated.
- The second line of code creates a precondition that is checked when the proof is sent to the blockchain to be verified.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second line of code creates a precondition that is checked when the proof is sent in a transaction the blockchain to be verified.

@garwalsh
Copy link
Contributor

@barriebyron
We don't need to draw the distinction between o1js and Mina FAQs here.
It's better framed as zkApp developer questions. They came directly from hackers at ZK Hack

docs/zkapps/faq.mdx Outdated Show resolved Hide resolved
@barriebyron barriebyron changed the title docs: new FAQs some are Mina docs: new FAQs from the ZK Hack Nov 17, 2023
@barriebyron barriebyron merged commit 76cab6d into main Nov 17, 2023
1 of 2 checks passed
@barriebyron barriebyron deleted the faq-zkhack branch November 17, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: add FAQs from zkHack
4 participants