Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update performance-guidance.md #9962

Merged
merged 5 commits into from
Jan 6, 2025
Merged

Update performance-guidance.md #9962

merged 5 commits into from
Jan 6, 2025

Conversation

azarboon
Copy link
Contributor

@azarboon azarboon commented Dec 9, 2024

@WilliamDAssafMSFT thanks for combining the two sections. It was a good idea. I've added some more insights and tips to optimize connection pooling

Copy link
Contributor

@azarboon : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit eb62a0f:

✅ Validation status: passed

File Status Preview URL Details
azure-sql/database/performance-guidance.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@ttorble
Copy link
Contributor

ttorble commented Dec 9, 2024

@WilliamDAssafMSFT

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Dec 9, 2024
azure-sql/database/performance-guidance.md Outdated Show resolved Hide resolved
azure-sql/database/performance-guidance.md Outdated Show resolved Hide resolved
Rewrote it to accommodate feedbacks
@azarboon
Copy link
Contributor Author

@WilliamDAssafMSFT thank you for your constructive and spot-on feedbacks. Yes, I wrote those on Wikipedia to raise awareness but you are absolutely right that the doc should be more precise, actionable. I've edited it to accommodate your feedbacks. Please let me know your advice.

Copy link
Contributor

Learn Build status updates of commit 6ec9beb:

💡 Validation status: suggestions

File Status Preview URL Details
azure-sql/database/performance-guidance.md 💡Suggestion Details

azure-sql/database/performance-guidance.md

  • Line 267, Column 222: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/entra/identity-platform/refresh-tokens' will be broken in isolated environments. Replace with a relative link.
  • Line 268, Column 188: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/active-directory/conditional-access/howto-conditional-access-session-lifetime' will be broken in isolated environments. Replace with a relative link.
  • Line 270, Column 297: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/active-directory/reports-monitoring/concept-sign-ins' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 02c3431:

✅ Validation status: passed

File Status Preview URL Details
azure-sql/database/performance-guidance.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@azarboon
Copy link
Contributor Author

@WilliamDAssafMSFT thanks for edits. Can you please sign it off?

@WilliamDAssafMSFT
Copy link
Contributor

@azarboon Hi! This remains in review by a few others on the product group. Will update when ready.

Accommodated feedback regarding monitoring tokens
Copy link
Contributor

Learn Build status updates of commit 417bd7c:

✅ Validation status: passed

File Status Preview URL Details
azure-sql/database/performance-guidance.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@azarboon
Copy link
Contributor Author

@dimitri-furman thank you. I accomodated your feedback.

@WilliamDAssafMSFT
Copy link
Contributor

Just an update, @azarboon. Some of this guidance needs to be more nuanced. We are discussing internally. Holidays are slowing the conversation. Will be updating. No action imminent.

@azarboon
Copy link
Contributor Author

azarboon commented Dec 30, 2024

Just an update, @azarboon. Some of this guidance needs to be more nuanced. We are discussing internally. Holidays are slowing the conversation. Will be updating. No action imminent.

Thanks for update.

@v-dirichards v-dirichards added the keep-open Do not automatically close due to inactivity. label Dec 31, 2024
@WilliamDAssafMSFT
Copy link
Contributor

@azarboon thanks for getting the ball rolling on these changes. Your commit will be merged and this article update is in flight. After the updated article is published, GitHub will list you as an article contributor.

Thanks again for this feedback, your suggestions help improve our documentation.

Copy link
Contributor

Learn Build status updates of commit c1e9316:

✅ Validation status: passed

File Status Preview URL Details
azure-sql/database/performance-guidance.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@WilliamDAssafMSFT
Copy link
Contributor

#sign-off

@Jak-MS Jak-MS merged commit 2c967e6 into MicrosoftDocs:live Jan 6, 2025
2 checks passed
Copy link
Contributor

PR 9962 has been merged from azarboon:patch-5 to MicrosoftDocs:live by Jak-MS.

@azarboon, @WilliamDAssafMSFT, @dimitri-furman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aq-pr-triaged tracking label for the PR review team azure-sql-database/svc Change sent to author keep-open Do not automatically close due to inactivity. performance/subsvc ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants