-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type.Is Nullable Type Rule Clarification #200
Conversation
@bgribaudo : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 30d1f95: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Can you review the proposed changes? When the changes are ready for publication, add a #label:"aq-pr-triaged" |
@bgribaudo, @ehrenMSFT - has this pull request reached a conclusion? Is it ready to be merged? |
My feedback above still applies. |
@DougKlopfenstein, thanks for checking up on this. This is blocked by #203. (That PR renames a term in the language spec which can then be used here to resolve @ehrenMSFT's feedback.) |
Learn Build status updates of commit a4eb363: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Co-authored-by: Ehren <[email protected]>
Learn Build status updates of commit e23d11c: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@DougKlopfenstein, given Ehren's approval, was there anything else needed from me on this? |
Looks OK. Merging. |
Thank you, @DougKlopfenstein! |
Per https://learn.microsoft.com/en-us/powerquery-m/m-spec-types#type-equivalence-and-compatibility, this function's second parameter should only ever be a nullable primitive type.
This PR adds details about this requirement to the function's docs.