Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type.Is Nullable Type Rule Clarification #200

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

bgribaudo
Copy link
Contributor

Per https://learn.microsoft.com/en-us/powerquery-m/m-spec-types#type-equivalence-and-compatibility, this function's second parameter should only ever be a nullable primitive type.

This PR adds details about this requirement to the function's docs.

Copy link
Contributor

@bgribaudo : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 30d1f95:

✅ Validation status: passed

File Status Preview URL Details
query-languages/m/type-is.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Apr 30, 2024

@DougKlopfenstein

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Apr 30, 2024
@DougKlopfenstein
Copy link
Collaborator

@bgribaudo, @ehrenMSFT - has this pull request reached a conclusion? Is it ready to be merged?

@ehrenMSFT
Copy link
Contributor

@bgribaudo, @ehrenMSFT - has this pull request reached a conclusion? Is it ready to be merged?

My feedback above still applies.

@bgribaudo
Copy link
Contributor Author

@DougKlopfenstein, thanks for checking up on this. This is blocked by #203. (That PR renames a term in the language spec which can then be used here to resolve @ehrenMSFT's feedback.)

Copy link
Contributor

Learn Build status updates of commit a4eb363:

✅ Validation status: passed

File Status Preview URL Details
query-languages/m/type-is.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

query-languages/m/type-is.md Outdated Show resolved Hide resolved
Co-authored-by: Ehren <[email protected]>
Copy link
Contributor

Learn Build status updates of commit e23d11c:

✅ Validation status: passed

File Status Preview URL Details
query-languages/m/type-is.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@bgribaudo
Copy link
Contributor Author

@DougKlopfenstein, given Ehren's approval, was there anything else needed from me on this?

@DougKlopfenstein
Copy link
Collaborator

Looks OK. Merging.

@DougKlopfenstein DougKlopfenstein merged commit cb3ebbf into MicrosoftDocs:main Jan 29, 2025
2 checks passed
@bgribaudo
Copy link
Contributor Author

Thank you, @DougKlopfenstein!

@bgribaudo bgribaudo deleted the patch-7 branch January 29, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants