Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Install preview channel" Step from GetStart & Sample articles #3241

Merged
merged 5 commits into from
Aug 1, 2024
Merged

Remove "Install preview channel" Step from GetStart & Sample articles #3241

merged 5 commits into from
Aug 1, 2024

Conversation

mikehoffms
Copy link
Contributor

@mikehoffms mikehoffms commented Aug 1, 2024 •
edited
Loading

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit e47f4e3:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/webview2/concepts/navigation-events.md ✅Succeeded View
microsoft-edge/webview2/get-started/win32.md ✅Succeeded View
microsoft-edge/webview2/get-started/winui.md ✅Succeeded View
microsoft-edge/webview2/get-started/wpf.md ✅Succeeded View
microsoft-edge/webview2/samples/webview2_sample_uwp.md ✅Succeeded View
microsoft-edge/webview2/samples/webview2apissample.md ✅Succeeded View
microsoft-edge/webview2/samples/webview2browser.md ✅Succeeded View
microsoft-edge/webview2/samples/webview2samplewincomp.md ✅Succeeded View
microsoft-edge/webview2/samples/webview2windowsformsbrowser.md ✅Succeeded View
microsoft-edge/webview2/samples/webview2wpfbrowser.md ✅Succeeded View
microsoft-edge/webview2/samples/wv2cdpextensionwpfsample.md ✅Succeeded View
microsoft-edge/webview2/samples/wv2deploymentwixcustomactionsample.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

victorhuangwq
victorhuangwq requested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@victorhuangwq victorhuangwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change requested, but otherwise looks good to me.

microsoft-edge/webview2/samples/webview2browser.md Outdated Show resolved Hide resolved
microsoft-edge/webview2/samples/webview2browser.md Outdated Show resolved Hide resolved
victorhuangwq
victorhuangwq approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@victorhuangwq victorhuangwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit ac9c6a5:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/webview2/concepts/navigation-events.md ✅Succeeded View
microsoft-edge/webview2/get-started/win32.md ✅Succeeded View
microsoft-edge/webview2/get-started/winui.md ✅Succeeded View
microsoft-edge/webview2/get-started/wpf.md ✅Succeeded View
microsoft-edge/webview2/samples/webview2_sample_uwp.md ✅Succeeded View
microsoft-edge/webview2/samples/webview2apissample.md ✅Succeeded View
microsoft-edge/webview2/samples/webview2browser.md ✅Succeeded View
microsoft-edge/webview2/samples/webview2samplewincomp.md ✅Succeeded View
microsoft-edge/webview2/samples/webview2windowsformsbrowser.md ✅Succeeded View
microsoft-edge/webview2/samples/webview2wpfbrowser.md ✅Succeeded View
microsoft-edge/webview2/samples/wv2cdpextensionwpfsample.md ✅Succeeded View
microsoft-edge/webview2/samples/wv2deploymentwixcustomactionsample.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit d2b0610:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/webview2/concepts/navigation-events.md ✅Succeeded View
microsoft-edge/webview2/get-started/win32.md ✅Succeeded View
microsoft-edge/webview2/get-started/winui.md ✅Succeeded View
microsoft-edge/webview2/get-started/wpf.md ✅Succeeded View
microsoft-edge/webview2/samples/webview2_sample_uwp.md ✅Succeeded View
microsoft-edge/webview2/samples/webview2apissample.md ✅Succeeded View
microsoft-edge/webview2/samples/webview2browser.md ✅Succeeded View
microsoft-edge/webview2/samples/webview2samplewincomp.md ✅Succeeded View
microsoft-edge/webview2/samples/webview2windowsformsbrowser.md ✅Succeeded View
microsoft-edge/webview2/samples/webview2wpfbrowser.md ✅Succeeded View
microsoft-edge/webview2/samples/wv2cdpextensionwpfsample.md ✅Succeeded View
microsoft-edge/webview2/samples/wv2deploymentwixcustomactionsample.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@Reezaali Reezaali merged commit 367c3e4 into main Aug 1, 2024
2 checks passed
@Reezaali Reezaali deleted the user/mikehoffms/preview-ch branch August 1, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorhuangwq victorhuangwq victorhuangwq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikehoffms @victorhuangwq @Reezaali