Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement server-side timeout setting via environment variable #3

Merged
merged 2 commits into from
Nov 21, 2018

Conversation

hexsprite
Copy link

No description provided.

@hexsprite
Copy link
Author

Just realized I forgot to create the PR! :)

@SimonSimCity
Copy link
Member

Thanks for taking the time of creating this PR. I'd like to merge this soon as well.

Please check if you'd not also get it working on the client side. This PR claims to also allow setting the timeout for the client: practicalmeteor#9

@hexsprite
Copy link
Author

@SimonSimCity it's not an itch I have at the moment and I can't spare any time to get it working on client side. As it, this does solve the server-side issue, so perhaps we can merge this and also work towards getting it working on client side when someone has the time?

@SimonSimCity SimonSimCity merged commit f87fa4d into Meteor-Community-Packages:master Nov 21, 2018
@SimonSimCity
Copy link
Member

@hexsprite thanks for providing the PR here. I've found some time yesterday to finish this up and test it through. The changes I've added to yours are visible here: d1cd5df

The major changes I did was renaming the environment variable to MOCHA_TIMEOUT which will set this timeout for the server and the client - it mainly was a code-copy of practicalmeteor#9.

@hexsprite
Copy link
Author

@SimonSimCity oh nice, that was a handy way of using Meteor.settings to pass data from server to client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants