german memes #455
german memes #455
Conversation
|
merge when? |
|
Previously rejected for being there for a few months without comment or mention, these tend to get merged by demand or relevance which I didn't see either at the time. Jokes that are in a different language in probably exactly one use-case seem like a bad idea, but if this is something people want it can be merged. |
|
rejecting the pull request saying that nobody will use it kinda sets a chicken and egg problem. according to your logic then no chatsounds could be added because they didnt get used before. also there are pull request from other people that also had no comments and got merged so your argument saying that pull request need comments or relevance is kinda weak since only a small portion of meta is actually looking up pull requests on the chatsound github page let alone commenting them. why not merge and remove the chatsounds in a future commit if they are actually rarely used? |
|
Names are not common words used for other chatsounds, the format of the files is ok, its only 4 sounds, merging. |
|
thank you |
why was is rejected?