fix: 🐛 fix insufficient funds displays incorrect native token #29828

matteoscurati · 2025-01-21T16:36:51Z

Description

This PR addresses an issue where the "Insufficient funds" alert incorrectly displayed "ETH" as the native token, regardless of the actual network's native token #28867. This was observed when users attempted to initiate a transaction on networks with a different native token, such as Polygon, where "POL" should be displayed instead of "ETH".

Related issues

#28867

Manual testing steps

Select Polygon
Trigger a dapp tx with an account without funds (you can use these tests https://metamask.github.io/test-dapp/)
Click on the Alert
See POL as the token name

Screenshots/Recordings

Before

After

https://www.loom.com/share/8dd8001fc8d44da3b77e52a4877427f8

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-01-21T16:37:08Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-01-21T17:11:15Z

Builds ready [969744b]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1681 ± 73 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1455	2122	1681	152	73
		domContentLoaded	1448	2109	1668	151	72
		load	1456	2122	1681	152	73
		domInteractive	24	139	49	25	12
		backgroundConnect	6	52	15	13	6
		firstReactRender	15	75	43	25	12
		getState	4	10	6	2	1
		initialActions	0	45	2	10	5
		loadScripts	1048	1653	1231	134	65
		setupStore	6	61	12	16	8
		uiStartup	1665	2415	1931	182	87

Bundle size diffs [🚀 Bundle size reduced!]

background: -1.65 KiB (-0.03%)
ui: 189 Bytes (0.00%)
common: -2 Bytes (-0.00%)

…t-native-token

metamaskbot · 2025-01-21T18:36:37Z

Builds ready [537f5ed]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1825 ± 138 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1493	2527	1828	283	136
		domContentLoaded	1485	2503	1803	281	135
		load	1494	2573	1825	287	138
		domInteractive	26	169	66	39	19
		backgroundConnect	6	66	22	17	8
		firstReactRender	16	92	44	28	13
		getState	5	72	15	18	8
		initialActions	0	1	0	0	0
		loadScripts	1083	2005	1365	248	119
		setupStore	6	62	19	21	10
		uiStartup	1802	2901	2133	288	138

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 192 Bytes (0.00%)
common: -2 Bytes (-0.00%)

…t-native-token

metamaskbot · 2025-01-24T14:54:42Z

Builds ready [776040a]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1956 ± 77 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1707	2268	1960	160	77
		domContentLoaded	1662	2254	1929	163	78
		load	1702	2265	1956	160	77
		domInteractive	27	81	42	17	8
		backgroundConnect	11	65	24	17	8
		firstReactRender	17	100	35	25	12
		getState	7	83	29	24	12
		initialActions	0	1	0	0	0
		loadScripts	1208	1730	1440	150	72
		setupStore	7	64	23	22	11
		uiStartup	1966	2886	2264	223	107

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 192 Bytes (0.00%)
common: -2 Bytes (-0.00%)

…t-native-token

metamaskbot · 2025-01-24T16:21:46Z

Builds ready [bb5ff52]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1747 ± 62 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1572	2116	1755	126	61
		domContentLoaded	1556	2103	1723	123	59
		load	1569	2119	1747	129	62
		domInteractive	25	94	43	21	10
		backgroundConnect	9	76	24	19	9
		firstReactRender	16	100	41	29	14
		getState	4	73	17	20	9
		initialActions	0	1	0	0	0
		loadScripts	1081	1553	1255	105	50
		setupStore	8	74	17	20	9
		uiStartup	1764	2499	2025	203	97

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 192 Bytes (0.00%)
common: -2 Bytes (-0.00%)

…t-native-token

metamaskbot · 2025-01-27T15:46:58Z

Builds ready [d5efd0f]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1724 ± 66 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	332	2086	1592	441	212
		domContentLoaded	1467	2074	1695	139	67
		load	1498	2088	1724	138	66
		domInteractive	25	143	49	33	16
		backgroundConnect	7	76	36	22	10
		firstReactRender	16	99	45	28	13
		getState	5	72	17	17	8
		initialActions	0	1	0	0	0
		loadScripts	1079	1596	1244	122	59
		setupStore	8	60	17	16	8
		uiStartup	1788	2889	1990	239	115

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 192 Bytes (0.00%)
common: -2 Bytes (-0.00%)

darkwing

Good solution @matteoscurati ! We do need a slight change though:

We can't simply change the English key because the other languages don't get re-translated. What we'll need to do is:

Create a new key in app/_locales/en/messages.json for the new string
Run yarn verify-locales:fix to remove the old, unused strings from other languages.

That way the string will get properly translated by our vendors.

…t-native-token

matteoscurati · 2025-01-29T17:55:58Z

@darkwing thx! I’ve created the new strings with the latest commit!

…t-native-token

metamaskbot · 2025-01-30T10:10:24Z

Builds ready [c1cd7ae]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1479 ± 32 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1396	1618	1482	69	33
		domContentLoaded	1366	1587	1459	64	31
		load	1397	1620	1479	67	32
		domInteractive	15	68	30	14	7
		backgroundConnect	8	53	24	15	7
		firstReactRender	14	93	37	27	13
		getState	4	9	6	2	1
		initialActions	0	0	0	0	0
		loadScripts	965	1149	1051	53	26
		setupStore	6	54	12	14	7
		uiStartup	1552	2018	1684	100	48

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 227 Bytes (0.00%)
common: 33 Bytes (0.00%)

fix: 🐛 fix insufficient funds displays incorrect native token

969744b

metamaskbot added the team-notifications DEPRECATED: Use "team-assets" instead label Jan 21, 2025

matteoscurati mentioned this pull request Jan 21, 2025

[Bug]: Send Alert - Insufficient funds displays incorrect native token as copy text and button text #28867

Closed

matteoscurati added team-assets and removed team-notifications DEPRECATED: Use "team-assets" instead labels Jan 21, 2025

Merge branch 'main' into fix/fix-insufficient-funds-displays-incorrec…

537f5ed

…t-native-token

Merge branch 'main' into fix/fix-insufficient-funds-displays-incorrec…

776040a

…t-native-token

Merge branch 'main' into fix/fix-insufficient-funds-displays-incorrec…

bb5ff52

…t-native-token

Merge branch 'main' into fix/fix-insufficient-funds-displays-incorrec…

d5efd0f

…t-native-token

matteoscurati marked this pull request as ready for review January 27, 2025 15:43

matteoscurati requested a review from a team as a code owner January 27, 2025 15:43

darkwing requested changes Jan 28, 2025

View reviewed changes

matteoscurati added 2 commits January 29, 2025 17:44

Merge branch 'main' into fix/fix-insufficient-funds-displays-incorrec…

2c7ede3

…t-native-token

feat:

cd72ba2

matteoscurati requested a review from darkwing January 29, 2025 17:56

OGPoyraz approved these changes Jan 30, 2025

View reviewed changes

Merge branch 'main' into fix/fix-insufficient-funds-displays-incorrec…

c1cd7ae

…t-native-token

darkwing approved these changes Jan 30, 2025

View reviewed changes

darkwing added this pull request to the merge queue Jan 30, 2025

Merged via the queue into main with commit 33ffbc5 Jan 30, 2025
70 checks passed

darkwing deleted the fix/fix-insufficient-funds-displays-incorrect-native-token branch January 30, 2025 14:11

github-actions bot locked and limited conversation to collaborators Jan 30, 2025

metamaskbot added the release-12.12.0 Issue or pull request that will be included in release 12.12.0 label Jan 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: 🐛 fix insufficient funds displays incorrect native token #29828

fix: 🐛 fix insufficient funds displays incorrect native token #29828

matteoscurati commented Jan 21, 2025 •

edited by github-actions bot

Loading

github-actions bot commented Jan 21, 2025

metamaskbot commented Jan 21, 2025

metamaskbot commented Jan 21, 2025

metamaskbot commented Jan 24, 2025

metamaskbot commented Jan 24, 2025

metamaskbot commented Jan 27, 2025

darkwing left a comment

matteoscurati commented Jan 29, 2025

metamaskbot commented Jan 30, 2025

fix: 🐛 fix insufficient funds displays incorrect native token #29828

fix: 🐛 fix insufficient funds displays incorrect native token #29828

Conversation

matteoscurati commented Jan 21, 2025 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jan 21, 2025

metamaskbot commented Jan 21, 2025

metamaskbot commented Jan 21, 2025

metamaskbot commented Jan 24, 2025

metamaskbot commented Jan 24, 2025

metamaskbot commented Jan 27, 2025

darkwing left a comment

Choose a reason for hiding this comment

matteoscurati commented Jan 29, 2025

metamaskbot commented Jan 30, 2025

matteoscurati commented Jan 21, 2025 •

edited by github-actions bot

Loading