Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove obsolete permitted chains feature flag tests #29618

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Jan 9, 2025

Description

Removes tests that are no longer applicable pertaining to permitted chains.

Open in GitHub Codespaces

Related issues

See: #27847 (comment)

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jiexi jiexi changed the title Remove obsolete permitted chains feature flag tests test: Remove obsolete permitted chains feature flag tests Jan 9, 2025
@jiexi jiexi marked this pull request as ready for review January 9, 2025 21:06
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

To other reviewers, I'd strongly recommend using the "Hide whitespace" option on the diff view

@jiexi jiexi enabled auto-merge January 9, 2025 21:38
@jiexi jiexi added this pull request to the merge queue Jan 9, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [d0de645]
Page Load Metrics (1712 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15421970171011957
domContentLoaded15331958168612158
load15441971171211957
domInteractive24164453617
backgroundConnect135929168
firstReactRender1577442512
getState64915136
initialActions01000
loadScripts11131490127410349
setupStore67113157
uiStartup17292303195315273

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2025
@Gudahtt Gudahtt added this pull request to the merge queue Jan 9, 2025
@Gudahtt
Copy link
Member

Gudahtt commented Jan 9, 2025

Kicked out of merge queue due to known flaky CI failure (#29482). I have re-added it.

Merged via the queue into main with commit 46bf1cf Jan 9, 2025
87 of 88 checks passed
@Gudahtt Gudahtt deleted the jl/remove-dead-permitted-chains-flag-tests branch January 9, 2025 23:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-wallet-api-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants