Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jl/caip25 permission migration/fix wallet request permissions delay grant #29613

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Jan 9, 2025

Description

Restores wallet_requestPermissions atomicity by delaying CAIP-25 grant until after other grants if they are requested

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jiexi jiexi marked this pull request as ready for review January 9, 2025 19:15
@jiexi jiexi merged commit 368fccb into caip25-permission-migration Jan 9, 2025
67 of 68 checks passed
@jiexi jiexi deleted the jl/caip25-permission-migration/fix-wallet-requestPermissions-delay-grant branch January 9, 2025 19:15
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [afc95e3]
Page Load Metrics (1807 ± 56 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint35420391739337162
domContentLoaded15721984176110349
load15852044180711756
domInteractive28169594220
backgroundConnect9115493517
firstReactRender1796423115
getState588272612
initialActions01000
loadScripts1142146213027938
setupStore675202210
uiStartup180927482208256123

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants