Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix flaky e2e for nft token send #29476

Merged
merged 9 commits into from
Jan 9, 2025
Merged

Conversation

pnarayanaswamy
Copy link
Contributor

@pnarayanaswamy pnarayanaswamy commented Jan 7, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes: #29382

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jan 7, 2025
@pnarayanaswamy pnarayanaswamy requested a review from a team as a code owner January 8, 2025 13:56
@metamaskbot
Copy link
Collaborator

Builds ready [a07a823]
Page Load Metrics (1689 ± 151 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27725471597430206
domContentLoaded137124371653303145
load138025231689314151
domInteractive20130473115
backgroundConnect987332311
firstReactRender15190644321
getState57816209
initialActions01000
loadScripts98818981249252121
setupStore689232914
uiStartup157231322087456219

@metamaskbot
Copy link
Collaborator

Builds ready [8a872b7]
Page Load Metrics (1619 ± 81 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint39619781563317152
domContentLoaded13541918159516077
load14001976161916981
domInteractive247542189
backgroundConnect76230178
firstReactRender1597362914
getState488182311
initialActions01000
loadScripts9901495118713766
setupStore65112126
uiStartup161023091899219105

@pnarayanaswamy pnarayanaswamy added this pull request to the merge queue Jan 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2025
@pnarayanaswamy pnarayanaswamy added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 93b1e13 Jan 9, 2025
77 checks passed
@pnarayanaswamy pnarayanaswamy deleted the fix-flaky-nft-token branch January 9, 2025 14:13
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix "Confirmation Redesign Token Send @no-mmi ERC721 Wall..." flaky tests
4 participants