Skip to content

Commit

Permalink
build: update node to v22.13.1 (#28368)
Browse files Browse the repository at this point in the history
## **Description**

Node LTS just moved to 22, let's start using it.

Keeping this as-is in package.json for now:
`"node": ">= 20",`

Was previously blocked by 101arrowz/fflate#227
Just merged this and now it's unblocked #29177

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28368?quickstart=1)

<!--## **Related issues**
## **Manual testing steps**
## **Screenshots/Recordings**
### **Before**
### **After**
## **Pre-merge author checklist**
## **Pre-merge reviewer checklist**-->
  • Loading branch information
HowardBraham authored Jan 24, 2025
1 parent 75be75c commit fad926a
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 13 deletions.
6 changes: 3 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@ version: 2.1
executors:
node-browsers-small:
docker:
- image: cimg/node:20.18-browsers
- image: cimg/node:22.13-browsers
resource_class: small
environment:
NODE_OPTIONS: --max_old_space_size=2048
node-browsers-medium:
docker:
- image: cimg/node:20.18-browsers
- image: cimg/node:22.13-browsers
resource_class: medium
environment:
NODE_OPTIONS: --max_old_space_size=3072
Expand All @@ -21,7 +21,7 @@ executors:
NODE_OPTIONS: --max_old_space_size=6144
node-browsers-medium-plus:
docker:
- image: cimg/node:20.18-browsers
- image: cimg/node:22.13-browsers
resource_class: medium+
environment:
NODE_OPTIONS: --max_old_space_size=4096
Expand Down
2 changes: 1 addition & 1 deletion .depcheckrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ ignores:
- '@metamask/phishing-warning' # statically hosted as part of some e2e tests
- '@metamask/test-dapp'
- '@metamask/design-tokens' # Only imported in index.css
- '@tsconfig/node20' # required dynamically by TS, used in tsconfig.json
- '@tsconfig/node22' # required dynamically by TS, used in tsconfig.json
- '@sentry/cli' # invoked as `sentry-cli`
- 'chromedriver'
- 'depcheck' # ooo meta
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v20.18
v22.13
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@
"@testing-library/react": "^10.4.8",
"@testing-library/react-hooks": "^8.0.1",
"@testing-library/user-event": "^14.4.3",
"@tsconfig/node20": "^20.1.2",
"@tsconfig/node22": "^22.0.0",
"@types/babelify": "^7.3.7",
"@types/browserify": "^12.0.37",
"@types/chrome": "^0.0.268",
Expand Down
4 changes: 2 additions & 2 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// directories that make sense for their environment.
// I think this would eliminate a lot of eslint overrides complexity
// In the meantime, we need DOM libs and should target the ES version in
// "@tsconfig/node20/tsconfig.json" (`libs` here overwrites extends's `libs`)
// "@tsconfig/node22/tsconfig.json" (`libs` here overwrites extends's `libs`)
"lib": ["DOM", "es2023"],
// we only use tsc for type checking (yarn lint:tsc)
"noEmit": true,
Expand All @@ -30,7 +30,7 @@
"**/*.stories.ts"
],
// this should match our node version in .nvmrc
"extends": "@tsconfig/node20/tsconfig.json",
"extends": "@tsconfig/node22/tsconfig.json",
"include": [
"app",
"development",
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -10174,10 +10174,10 @@ __metadata:
languageName: node
linkType: hard

"@tsconfig/node20@npm:^20.1.2":
version: 20.1.2
resolution: "@tsconfig/node20@npm:20.1.2"
checksum: 10/fc126e15f0817bd328c15bd6be7972f01ef4d55ceb493c7a83ccb9dd545e39f218711f330e3df4072b116b11180c07943da2b2bfcd7adc58414cb586db52a4c8
"@tsconfig/node22@npm:^22.0.0":
version: 22.0.0
resolution: "@tsconfig/node22@npm:22.0.0"
checksum: 10/9fc45789304640e1e37e1f1e04c02dca593c290d4f1cb55af7e9cab799fb2c6356e1cc15ee9f140185591a81f491a4c7f2d6c08c1e5a3d758658ba69f1afee6d
languageName: node
linkType: hard

Expand Down Expand Up @@ -26810,7 +26810,7 @@ __metadata:
"@testing-library/react-hooks": "npm:^8.0.1"
"@testing-library/user-event": "npm:^14.4.3"
"@trezor/connect-web": "npm:^9.4.0"
"@tsconfig/node20": "npm:^20.1.2"
"@tsconfig/node22": "npm:^22.0.0"
"@types/babelify": "npm:^7.3.7"
"@types/browserify": "npm:^12.0.37"
"@types/chrome": "npm:^0.0.268"
Expand Down

0 comments on commit fad926a

Please sign in to comment.